Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi-display Android system #1272

Closed
wants to merge 1 commit into from

Conversation

vblack
Copy link
Contributor

@vblack vblack commented Apr 7, 2020

Add -d, --display option to work with non-primary display in multi-
display Android configurations

Signed-off-by: Kostiantyn Luzan [email protected]

Add -d, --display option to work with non-primary display in multi-
display Android configurations

Signed-off-by: Kostiantyn Luzan <[email protected]>
@rom1v
Copy link
Collaborator

rom1v commented Apr 7, 2020

Hi,

Thank you for your work, but this has already been implemented by #1238 and merged into dev. cc @peanutwolf

I'm sorry for that, I did not really mention that dev is the development branch.
To try to avoid this in the future, I just added a branches section in BUILD.md. Maybe I should also add a pull request template (but it's too late to mention it there, if people have already done their work on master).

Anyway, your code contains changes that are not applied on dev, like registerRotationWatcher().
Could you checkout/test dev and propose the missing changes, please?

What multi-display device do you use? (I have no way to test this feature.)

@vblack
Copy link
Contributor Author

vblack commented Apr 7, 2020

Hi, yes that was funny :) no worries. I will create pull request for missing part.
I use proprietary 3-display device with touch on 2 of 3 screens, running Android 10.

@vblack vblack closed this Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants