Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrcpy-linux-v3.0.tar.gz is not gzipped as claimed by the file name #5581

Closed
sedrik opened this issue Dec 2, 2024 · 2 comments
Closed

scrcpy-linux-v3.0.tar.gz is not gzipped as claimed by the file name #5581

sedrik opened this issue Dec 2, 2024 · 2 comments

Comments

@sedrik
Copy link

sedrik commented Dec 2, 2024

Environment

  • OS: Ubuntu 24.04
  • Scrcpy version: 3.0
  • Installation method: github release download
  • Device model:
  • Android version: not applicable

Describe the bug

Based on the tar.gz file ending it is assumed that the tarball is gzipped, but it turns out that it is not as evident by the output bellow.

~/Downloads
❯ sha256sum scrcpy-linux-v3.0.tar.gz
06cb74e22f758228c944cea048b78e42b2925c2affe2b5aca901cfd6a649e503  scrcpy-linux-v3.0.tar.gz

~/Downloads
❯ cat SHA256SUMS.txt
800044c62a94d5fc16f5ab9c86d45b1050eae3eb436514d1b0d2fe2646b894ea  scrcpy-server-v3.0
06cb74e22f758228c944cea048b78e42b2925c2affe2b5aca901cfd6a649e503  scrcpy-linux-v3.0.tar.gz
7cbf8d7a6ebfdca7b3b161e29a481c11088305f3e0a89d28e8e62f70c7bd0028  scrcpy-win32-v3.0.zip
dfbe8a8fef6535197acc506936bfd59d0aa0427e9b44fb2e5c550eae642f72be  scrcpy-win64-v3.0.zip
5db9821918537eb3aaf0333cdd05baf85babdd851972d5f1b71f86da0530b4bf  scrcpy-macos-v3.0.tar.gz

~/Downloads
❯ tar -xvzf scrcpy-linux-v3.0.tar.gz

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now

~/Downloads
❯ tar -xvf scrcpy-linux-v3.0.tar.gz
scrcpy-linux-v3.0/
scrcpy-linux-v3.0/scrcpy-server
scrcpy-linux-v3.0/icon.png
scrcpy-linux-v3.0/scrcpy
scrcpy-linux-v3.0/adb
scrcpy-linux-v3.0/scrcpy.1
scrcpy-linux-v3.0/scrcpy_bin
rom1v added a commit that referenced this issue Dec 2, 2024
The generated .tar.gz releases were in fact non-gzipped tarballs.

Fixes #5581 <#5581>
@rom1v
Copy link
Collaborator

rom1v commented Dec 2, 2024

Oh, thank you. Good catch!

I thought that tar inferred the compression from the file extension when the flag was not explicit, that's not true.

Fixed by 36574d2 🚀

@rom1v rom1v closed this as completed Dec 2, 2024
@sedrik
Copy link
Author

sedrik commented Dec 2, 2024

Thanks for the quick fix and an awesome project <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants