2.6 mouse issues

[chinagaofeng]

as 2.6 said:

By default, a simple click triggers the shortcuts, and Shift+click forwards the click to the device.

I hate this default setting! It makes very inconvenience for control than 2.5. I have to roll-back.

my cli is just "scrcpy -Sw", means I use SDK mouse

[rom1v]

I hate this default setting! It makes very inconvenience for control than 2.5. I have to roll-back.

If you just click (with a secondary button), it is the same behavior as v2.5… and earlier versions.

What changes is only when you Shift+click, there are new bindings.

[chinagaofeng]

I hate this default setting! It makes very inconvenience for control than 2.5. I have to roll-back.

If you just click (with a secondary button), it is the same behavior as v2.5… and earlier versions.

What changes is only when you Shift+click, there are new bindings.

not exactly same, for example: in 2.5-, holding left button and dragging, works same as middle button scrolling; but in 2.6, holding-dragging works but mid-scrolling not works, or mid-scrolling works while holding-dragging not works, can't determine why

[vferrenq]

I encounter also a problem with 2.6 (Ubuntu 22.04). A simple left click acts as a long press. I have also to rollback to 2.5 and everything works as expected.

[rom1v]

OK, that's a bug then. Not caused by the binding changes directly, but probably by either 6808288, 51fee79 or 6baea57.

I will bisect and investigate (hopefully tonight or tomorrow).

[vidoardes]

I am also experiencing this issue, is there an easy way to downgrade on Fedora? I tried sudo dnf downgrade scrcpy but it appears previous versions of the package has been removed

[rom1v]

but in 2.6, holding-dragging works but mid-scrolling not works, or mid-scrolling works while holding-dragging not works

OK, so now I'm on my computer, I tried to reproduce, but I fail. For example, in the settings, I can either scroll or click & drag.

Is it "random"? Or 100% reproducible?

Could you please give more information:

• what device model?
• in which app does it happen?

[rom1v]

Oh, I understand, in Firefox, I can scroll using middle-scroll, but not by click&drag (because now it behaves like a mouse rather than a finger). This is definitely due to 6808288.

So I will need to restore a pointer, but that will cause other problems (for example, mouse hover needs a mouse: #5067). Will need to find something which works for all cases.

[rom1v]

Oh, using a "finger" tool type in all cases seems to be sufficient:

diff --git a/server/src/main/java/com/genymobile/scrcpy/control/Controller.java b/server/src/main/java/com/genymobile/scrcpy/control/Controller.java
index 85425113a..a5cda74cf 100644
--- a/server/src/main/java/com/genymobile/scrcpy/control/Controller.java
+++ b/server/src/main/java/com/genymobile/scrcpy/control/Controller.java
@@ -278,14 +278,16 @@ public class Controller implements AsyncProcessor {
         pointer.setPressure(pressure);
 
         int source;
+
+        // Always behave like a finger (to scroll a page via Click+drag)
+        pointerProperties[pointerIndex].toolType = MotionEvent.TOOL_TYPE_FINGER;
+
         if (pointerId == POINTER_ID_MOUSE) {
             // real mouse event
-            pointerProperties[pointerIndex].toolType = MotionEvent.TOOL_TYPE_MOUSE;
             source = InputDevice.SOURCE_MOUSE;
             pointer.setUp(buttons == 0);
         } else {
             // POINTER_ID_GENERIC_FINGER, POINTER_ID_VIRTUAL_FINGER or real touch from device
-            pointerProperties[pointerIndex].toolType = MotionEvent.TOOL_TYPE_FINGER;
             source = InputDevice.SOURCE_TOUCHSCREEN;
             // Buttons must not be set for touch events
             buttons = 0;

Please test by replacing this file in the scrcpy v2.6 release folder:

• scrcpy-server SHA-256: 9ceb957ade7f2df9c59e8b8af8856239365687a05e4624c39bee2decff9f5e0

[rom1v]

@vidoardes you can download the scrcpy-server above and test with:

export SCRCPY_SERVER_PATH=/xxx/scrcpy-server  # adapt the path
scrcpy

[vidoardes]

@vidoardes you can download the scrcpy-server above and test with:

export SCRCPY_SERVER_PATH=/xxx/scrcpy-server  # adapt the path
scrcpy

I can confirm it fixes scrolling in Firefox, but not in all apps. Not sure what the difference is, but one example is a game call Gold & Goblins which doesn't now work (but did in 2.5)

[rom1v]

OK, thank you very much. Now I can reproduce and debug easily 👍

The the trick in #5162 (comment) is not correct: it works only if the input is a SOURCE_TOUCHSCREEN. So back to the previous comment (#5162 (comment)). Will need more thinking to make everything work with a single solution.

[rom1v]

Please test with this change (89288c9):

• scrcpy-server SHA-256: 6a4a5f2f14a511ab64e8717e0c0c1fb173a57cad4f53cc6ad8e19aba6715de8

[rom1v]

Fixed in scrcpy 2.6.1.