screen rotation

[dude105tanki]

I have a bug on my LG device where the screen on my pc is rotated 90 degrees but still functions as if the touches were not. it is similar to this issue, #186

but the reference there doesn't help me.

how do i fix this bug and/or rotate the screen on my pc

[rom1v]

Also similar to #481.

[dude105tanki]

kinda
more like this, I suck at explaining things anyways.
https://youtu.be/kVBgShD9E_w

[codeandcreate]

This also happens to the planet computers gemini.

[syockit]

On Planet Computers Gemini PDA, when I modify the DisplayManager wrapper to use appWidth/Height instead of logicalWidth/Height, the correct orientation is displayed for some apps (including the home screen), but still fails for full screen application (games). The logical dimensions are 2160x1080, while the reported appWidth/Height are 2032x1080. The cropped 128 pixels correspond to the android buttons which appear to the right.

Playing around with contentRect width, I found that the correction orientation is displayed when width is ≤ 2038 pixels. There's probably something on the android side that rotates the display when requesting content above certain dimensions.

Currently, as a workaround for viewing full screen games, I hardcoded the rotation set by setDisplayProjection to 3 (taking hint from Ihttps://github.com//pull/1151).

[rom1v]

It seems scrcpy is incapible of rotating the screen properly when it detects a rotation with or without the keybind.

In fact, it does... when the device/ROM correctly notifies the rotation event:

https://github.com/Genymobile/scrcpy/blob/master/server/src/main/java/com/genymobile/scrcpy/Device.java#L30

[rom1v]

Clearly something wrong with the code if it can't switch between Portrait and Landscape modes interchangeably without stretching or squashing the screen proportions and render it correctly.

Of course something is wrong. To handle this properly, scrcpy restart the video encoding when the device notifies the rotation change (because the video dimension change).

It works pretty well. But some devices (apparently) do not call the onRotationChange callback, so in that case the video encoding is not restarted, and stretch the new screen surface to the old dimensions on the device side.

Because the device is correctly notifies for the rotation event.

Are you sure?

Could you add a log here:

scrcpy/server/src/main/java/com/genymobile/scrcpy/Device.java

Lines 57 to 64 in 1a9429f

	synchronized (Device.this) {
	screenInfo = screenInfo.withDeviceRotation(rotation);
	// notify
	if (rotationListener != null) {
	rotationListener.onRotationChanged(rotation);
	}
	}

and verify that it is printed when you rotate your device?