Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen is small on pc when rotated (landscape) #481

Closed
Karma1233 opened this issue Mar 28, 2019 · 3 comments
Closed

Screen is small on pc when rotated (landscape) #481

Karma1233 opened this issue Mar 28, 2019 · 3 comments
Labels

Comments

@Karma1233
Copy link

This is my issue, detailed in a video so it is clear as to what I'm referring to...
https://youtu.be/l-uwNVsHVDA

I LOVE THIS PROGRAM. I'm not bashing or anything. This thing rocks. Just... would be better if actually went fullscreen or something. It looks like crap and is tiny when in landscape mode. If this could be corrected, it would literally be the BEST mirroring program ever created (at least for how I'm using it).

@rom1v rom1v added the rotation label Mar 28, 2019
@rom1v
Copy link
Collaborator

rom1v commented Mar 28, 2019

This is my issue, detailed in a video so it is clear as to what I'm referring to...

Great report! Thank you.

I'm not bashing or anything.

Bug reports are a good thing 😉

On your video, when you rotate the device, a New texture should have been printed:

INFO: Initial texture: 1080x2160
INFO: New texture: 2160x1080

Do you use the last version (v1.8)? (it was not correctly printed on previous versions)

If it isn't printed with v1.8, then the rotation is not detected on the device-side (in other words, this callback is not called as expected). I think this is the case, because otherwise the window would have been automatically resized, and we still see the not-so-black portrait rectangle.

Does it happen with all apps, or only this camera app (some camera apps have a specific rotation behavior, cf #218)?

Might also be related to: #186.

@Karma1233
Copy link
Author

Karma1233 commented Mar 28, 2019

Do you use the last version (v1.8)? (it was not correctly printed on previous versions)

Yes, I am using v1.8 (had to check and make sure)

Does it happen with all apps, or only this camera app (some camera apps have a specific rotation behavior, cf #218)?

Turns out, your hunch was correct! It works with other apps that go landscape on my phone (ie Hearthstone, Gmail, Twitch). I guess it's the built-in Camera app that has the rotation behavior you're referring to.

To work around this issue with my Camera app, I downloaded a different one (Open Camera) and it works fine. Thanks again for your help. I use this to watch my infant in the other room on my second monitor so that I can get work done at home.

Just for some extra info, I'm using an LG Stylo 4+ with Android 8.1.0. My Camera App is the Default Camera App that comes with the phone named "Camera" version 7.0.172
Thanks again! Loving Scrcpy!

@rom1v
Copy link
Collaborator

rom1v commented Mar 28, 2019

Great 👍

I cannot totally explain the behavior though. I think I will need to reproduce the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants