Honor Android 14 devices --turn-screen-off failed #4823

eiyooooo · 2024-04-07T03:29:37Z

I have read the FAQ.
I have searched in existing issues.

Environment

OS: [ALL]
scrcpy version: [2.4]
installation method: [ALL]
device model:Honor Android 14 devices, e.g. HONOR REP-AN00
Android version: [14]

Describe the bug
When server reaching here

scrcpy/server/src/main/java/com/genymobile/scrcpy/wrappers/DisplayControl.java

Line 31 in 206809a

    
           loadMethod.invoke(Runtime.getRuntime(), displayControlClass, "android_servers");

server get killed, cause by

Native registration unable to find class 'com/android/server/TrustedUIService'; aborting...

The text was updated successfully, but these errors were encountered:

eiyooooo · 2024-04-07T03:45:49Z

Temporary solution: not change the power mode for all physical displays, use SurfaceControl to change only one display instead

zoukyle · 2024-04-18T12:14:16Z

My device is being affected by this bug too. @eiyooooo is there a walk-around for this issue? Thanks!

eiyooooo · 2024-04-18T12:25:43Z

Is there a walk-around for this issue?

Temporary solution: not change the power mode for all physical displays, use SurfaceControl to change only one display instead

git diff
diff --git a/server/src/main/java/com/genymobile/scrcpy/Device.java b/server/src/main/java/com/genymobile/scrcpy/Device.java
index 8d0ee231..671ef2c5 100644
--- a/server/src/main/java/com/genymobile/scrcpy/Device.java
+++ b/server/src/main/java/com/genymobile/scrcpy/Device.java
@@ -319,7 +319,8 @@ public final class Device {
      * @param mode one of the {@code POWER_MODE_*} constants
      */
     public static boolean setScreenPowerMode(int mode) {
-        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q
+                && !(Build.BRAND.toLowerCase() + Build.MANUFACTURER.toLowerCase()).contains("honor")) {
             // On Android 14, these internal methods have been moved to DisplayControl
:

AndroidDeveloperLB · 2024-05-27T06:06:40Z

Note that Android Studio somehow does work with this.
Perhaps it would be good to check its code.

Also this update of Honor is terrible. Battery drains fast on it.

rom1v · 2024-07-17T10:23:12Z

@eiyooooo Does this also work:

diff --git a/server/src/main/java/com/genymobile/scrcpy/device/Device.java b/server/src/main/java/com/genymobile/scrcpy/device/Device.java
index ae4f50e59..3bd6b04c7 100644
--- a/server/src/main/java/com/genymobile/scrcpy/device/Device.java
+++ b/server/src/main/java/com/genymobile/scrcpy/device/Device.java
@@ -323,7 +323,16 @@ public final class Device {
      * @param mode one of the {@code POWER_MODE_*} constants
      */
     public static boolean setScreenPowerMode(int mode) {
-        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
+        boolean applyToMultiPhysicalDisplays = Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q;
+
+        if (applyToMultiPhysicalDisplays && Build.BRAND.equalsIgnoreCase("honor") && SurfaceControl.hasGetBuildInDisplayMethod()) {
+            // Workaround for Honor devices with Android 14:
+            //  - <https://github.com/Genymobile/scrcpy/issues/4823>
+            //  - <https://github.com/Genymobile/scrcpy/issues/4943>
+            applyToMultiPhysicalDisplays = false;
+        }
+
+        if (applyToMultiPhysicalDisplays) {
             // On Android 14, these internal methods have been moved to DisplayControl
             boolean useDisplayControl =
                     Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE && !SurfaceControl.hasPhysicalDisplayIdsMethod();
diff --git a/server/src/main/java/com/genymobile/scrcpy/wrappers/SurfaceControl.java b/server/src/main/java/com/genymobile/scrcpy/wrappers/SurfaceControl.java
index fc18a8e27..2ac1344e8 100644
--- a/server/src/main/java/com/genymobile/scrcpy/wrappers/SurfaceControl.java
+++ b/server/src/main/java/com/genymobile/scrcpy/wrappers/SurfaceControl.java
@@ -94,6 +94,15 @@ public final class SurfaceControl {
         return getBuiltInDisplayMethod;
     }
 
+    public static boolean hasGetBuildInDisplayMethod() {
+        try {
+            getGetBuiltInDisplayMethod();
+            return true;
+        } catch (NoSuchMethodException e) {
+            return false;
+        }
+    }
+
     public static IBinder getBuiltInDisplay() {
         try {
             Method method = getGetBuiltInDisplayMethod();

?

AndroidDeveloperLB · 2024-07-17T10:47:03Z

@rom1v Send me the files to run, and I will try...

rom1v · 2024-07-17T10:51:30Z

@AndroidDeveloperLB The patch above applied on current master (basically v2.5):

scrcpy-server _{SHA-256: 1f17da76699caa3af102563362cc50647ecc9a2a270577e7585c4a54d3063fc}

eiyooooo · 2024-07-17T12:31:57Z

Does this also work:

I make a little improvement at #5109.

AndroidDeveloperLB · 2024-07-17T12:45:05Z

@rom1v About this:
#4823 (comment)

Seems to work fine too (on the device I've mentioned).
Please don't change it for other devices and Android versions though, as maybe it will be ok on Android 15, so please come back here after it's published to see if this fix is needed there as well, instead of applying this fix there too without a need for it.

Fixes #4823 <#4823> PR #5109 <#5109> Signed-off-by: Romain Vimont <[email protected]>

rom1v · 2024-07-17T16:03:47Z

Merged 👍 9d1d79b

Please don't change it for other devices and Android versions though

It is very specific to Honor on Android 14 where the alternate method exists.

Fixes Genymobile#4823 <Genymobile#4823> PR Genymobile#5109 <Genymobile#5109> Signed-off-by: Romain Vimont <[email protected]>

wxjv99 · 2024-12-21T11:19:55Z

Temporary solution: not change the power mode for all physical displays, use SurfaceControl to change only one display instead

This code may have solved the problem, but it needs to revert the temporary solution(#5109) and use Honor device for testing.

yume-chan · 2024-12-22T12:51:19Z

This is #4544 (comment) with #5109 reverted: scrcpy-server.zip (for client version 3.1)

Please test Alt + O/Alt + Shift + O on Honor devices

Diff

diff --git a/server/src/main/java/com/genymobile/scrcpy/device/Device.java b/server/src/main/java/com/genymobile/scrcpy/device/Device.java
index 3553dc27..5f84e3b0 100644
--- a/server/src/main/java/com/genymobile/scrcpy/device/Device.java
+++ b/server/src/main/java/com/genymobile/scrcpy/device/Device.java
@@ -135,20 +135,8 @@ public final class Device {
             return ServiceManager.getDisplayManager().requestDisplayPower(displayId, on);
         }
 
-        boolean applyToMultiPhysicalDisplays = Build.VERSION.SDK_INT >= AndroidVersions.API_29_ANDROID_10;
-
-        if (applyToMultiPhysicalDisplays
-                && Build.VERSION.SDK_INT >= AndroidVersions.API_34_ANDROID_14
-                && Build.BRAND.equalsIgnoreCase("honor")
-                && SurfaceControl.hasGetBuildInDisplayMethod()) {
-            // Workaround for Honor devices with Android 14:
-            //  - <https://github.com/Genymobile/scrcpy/issues/4823>
-            //  - <https://github.com/Genymobile/scrcpy/issues/4943>
-            applyToMultiPhysicalDisplays = false;
-        }
-
         int mode = on ? POWER_MODE_NORMAL : POWER_MODE_OFF;
-        if (applyToMultiPhysicalDisplays) {
+        if (Build.VERSION.SDK_INT >= AndroidVersions.API_29_ANDROID_10) {
             // On Android 14, these internal methods have been moved to DisplayControl
             boolean useDisplayControl =
                     Build.VERSION.SDK_INT >= AndroidVersions.API_34_ANDROID_14 && !SurfaceControl.hasGetPhysicalDisplayIdsMethod();
diff --git a/server/src/main/java/com/genymobile/scrcpy/wrappers/SurfaceControl.java b/server/src/main/java/com/genymobile/scrcpy/wrappers/SurfaceControl.java
index 3bae4a37..b8b41b91 100644
--- a/server/src/main/java/com/genymobile/scrcpy/wrappers/SurfaceControl.java
+++ b/server/src/main/java/com/genymobile/scrcpy/wrappers/SurfaceControl.java
@@ -95,15 +95,6 @@ public final class SurfaceControl {
         return getBuiltInDisplayMethod;
     }
 
-    public static boolean hasGetBuildInDisplayMethod() {
-        try {
-            getGetBuiltInDisplayMethod();
-            return true;
-        } catch (NoSuchMethodException e) {
-            return false;
-        }
-    }
-
     public static IBinder getBuiltInDisplay() {
         try {
             Method method = getGetBuiltInDisplayMethod();

eiyooooo mentioned this issue May 27, 2024

Bug: after OS update, Honor Magic4 pro can't be mirrored with screen turned off using ScrCpy (closes right away), but can be via Android Studio #4943

Closed

YumeMichi mentioned this issue Jun 18, 2024

控制时关闭屏幕失效 viarotel-org/escrcpy#185

Closed

eiyooooo mentioned this issue Jul 17, 2024

Fix Honor Android 14 devices --turn-screen-off failed #5109

Closed

rom1v pushed a commit that referenced this issue Jul 17, 2024

Fix "turn screen off" for Honor Android 14 devices

9d1d79b

Fixes #4823 <#4823> PR #5109 <#5109> Signed-off-by: Romain Vimont <[email protected]>

eiyooooo closed this as completed Jul 20, 2024

FreedomBen pushed a commit to FreedomBen/scrcpy that referenced this issue Aug 2, 2024

Fix "turn screen off" for Honor Android 14 devices

4c52d8e

Fixes Genymobile#4823 <Genymobile#4823> PR Genymobile#5109 <Genymobile#5109> Signed-off-by: Romain Vimont <[email protected]>

rom1v mentioned this issue Aug 21, 2024

scrcpy failling to boot #5193

Open

hupan666 mentioned this issue Aug 26, 2024

荣耀Honor Android14无法熄屏 barry-ran/QtScrcpy#1028

Open

Gottox pushed a commit to Gottox/scrcpy that referenced this issue Sep 29, 2024

Fix "turn screen off" for Honor Android 14 devices

f1034ec

Fixes Genymobile#4823 <Genymobile#4823> PR Genymobile#5109 <Genymobile#5109> Signed-off-by: Romain Vimont <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Honor Android 14 devices --turn-screen-off failed #4823

Honor Android 14 devices --turn-screen-off failed #4823

eiyooooo commented Apr 7, 2024 •

edited

Loading

eiyooooo commented Apr 7, 2024 •

edited

Loading

zoukyle commented Apr 18, 2024

eiyooooo commented Apr 18, 2024

AndroidDeveloperLB commented May 27, 2024 •

edited

Loading

rom1v commented Jul 17, 2024 •

edited

Loading

AndroidDeveloperLB commented Jul 17, 2024

rom1v commented Jul 17, 2024

eiyooooo commented Jul 17, 2024

AndroidDeveloperLB commented Jul 17, 2024 •

edited

Loading

rom1v commented Jul 17, 2024

wxjv99 commented Dec 21, 2024 •

edited

Loading

yume-chan commented Dec 22, 2024

Honor Android 14 devices --turn-screen-off failed #4823

Honor Android 14 devices --turn-screen-off failed #4823

Comments

eiyooooo commented Apr 7, 2024 • edited Loading

eiyooooo commented Apr 7, 2024 • edited Loading

zoukyle commented Apr 18, 2024

eiyooooo commented Apr 18, 2024

AndroidDeveloperLB commented May 27, 2024 • edited Loading

rom1v commented Jul 17, 2024 • edited Loading

AndroidDeveloperLB commented Jul 17, 2024

rom1v commented Jul 17, 2024

eiyooooo commented Jul 17, 2024

AndroidDeveloperLB commented Jul 17, 2024 • edited Loading

rom1v commented Jul 17, 2024

wxjv99 commented Dec 21, 2024 • edited Loading

yume-chan commented Dec 22, 2024

eiyooooo commented Apr 7, 2024 •

edited

Loading

eiyooooo commented Apr 7, 2024 •

edited

Loading

AndroidDeveloperLB commented May 27, 2024 •

edited

Loading

rom1v commented Jul 17, 2024 •

edited

Loading

AndroidDeveloperLB commented Jul 17, 2024 •

edited

Loading

wxjv99 commented Dec 21, 2024 •

edited

Loading