MR #3817 Breaks launching scrcpy-console using the .desktop file

[gardotd426]

• [x ] I have read the FAQ.
• [ x] I have searched in existing issues.

Environment

• OS: Arch Linux
• scrcpy version: Master
• installation method: From source via AUR
• model: N/A
• Android version: N/A

Describe the bug
#3817 breaks scrcpy-console, because there are one too many backslashes in the Exec line.

/bin/bash --norc --noprofile -i -c "\"\\$SHELL\" -i -c scrcpy || read -p 'Press Enter to quit...'"

errors out, because it reads it as \/bin/zsh (or \/bin/bash, \/bin/fish, etc) and gives you a \/bin/zsh: no such file or directory error.

Removing one of the backslashes before $SHELL fixes the problem completely and you can launch scrcpy-console from the .desktop file as intended.

bash: \/bin/zsh: No such file or directory
Press Enter to quit...

Here's what happens when I run /bin/bash --norc --noprofile -i -c "\"\$SHELL\" -i -c scrcpy || read -p 'Press Enter to quit...'":

scrcpy 2.1.1 <https://github.com/Genymobile/scrcpy>
ERROR: Could not find any ADB device
ERROR: Server connection failed
Press Enter to quit...

Obviously I don't have adb running so that error can be ignored, when I have adb running and a device connected, it functions.

This may be a new issue due to Plasma updating or , but during my update I got this warning and many similar other warnings about other desktop files:

kf.config.core: "KConfigIni: In file /usr/share/applications/scrcpy-console.desktop, line 8: " "Invalid escape sequence \"\\\"\"."

kf.config.core: "KConfigIni: In file /usr/share/applications/scrcpy-console.desktop, line 8: " "Invalid escape sequence \"\\\"\"."

[rom1v]

Thank you for your report.

After #4130 (on dev branch), the .desktop scripts have been simplified a bit.

Could you please open a PR based on dev branch which fixes this issue?

[gardotd426]

I sure can. Its 3 AM here so I'll do it when I wake up.

…

On Sat, Oct 21, 2023, 2:59 AM Romain Vimont ***@***.***> wrote: Thank you for your report. After #4130 <#4130> (on dev branch), the .desktop scripts have been simplified a bit. Could you please open a PR based on dev branch which fixes this issue? — Reply to this email directly, view it on GitHub <#4367 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AM5Y33ZPHUCWOMKGZ7Z6VGLYANXFBAVCNFSM6AAAAAA6J36Z7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTGY4TQMRZHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[rom1v]

Did you have time to take a look?