Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty symlink when using WinGet #4027

Closed
2 tasks done
headquarter8302 opened this issue May 23, 2023 · 6 comments · Fixed by microsoft/winget-pkgs#196442
Closed
2 tasks done

Faulty symlink when using WinGet #4027

headquarter8302 opened this issue May 23, 2023 · 6 comments · Fixed by microsoft/winget-pkgs#196442

Comments

@headquarter8302
Copy link
Contributor

headquarter8302 commented May 23, 2023

  • I have read the FAQ.
  • I have searched in existing issues.

Environment

  • OS: Windows 10
  • scrcpy version: 2.0
  • installation method: winget
  • device model: Lenovo P1M
  • Android version: 5.1

Describe the bug
After installing through winget, a symlink is generated at %LOCALAPPDATA%\Microsoft\WinGet\Links as a mean of getting the executable into Path. However, when executing the symlink through the terminal (PowerShell 7.3.4 Core on Win10), it doesn't execute anything, just outputting nothing and returning to prompt. Even though manually going through the directory using File Explorer and opening it by double-clicking will launch it as normal.

 ASUS  PS  Monday 09:20:08 PM
 C:\Users\ASUS
  scrcpy

 ASUS  PS  Monday 09:20:12 PM
 C:\Users\ASUS
 

And no, the custom PS profile isn't interfering with anything. Heck, running with -noprofile will return an error instead, as if there was no symlink at all.

PowerShell 7.3.4
PS C:\Users\ASUS> scrcpy
scrcpy: The term 'scrcpy' is not recognized as a name of a cmdlet, function, script file, or executable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
PS C:\Users\ASUS>

However, executing the command via cmd.exe results in a stream of error prompts instead, reading: "The code execution cannot proceed because [multiple DLLs] was not found. Reinstalling the program may fix this problem."

@rom1v
Copy link
Collaborator

rom1v commented May 23, 2023

Please report to WinGet, I'm not the author of the WinGet package.

@headquarter8302
Copy link
Contributor Author

WinGet repo confirmed that this is an upstream issue with their app not being able to handle portable executables with DLLs

@rom1v
Copy link
Collaborator

rom1v commented May 24, 2023

their app not being able to handle portable executables with DLLs

Then they should probably build a non-portable version and use the dependencies (ffmpeg, sdl, libusb) from their repo:

option('portable', type: 'boolean', value: false, description: 'Use scrcpy-server from the same directory as the scrcpy executable')

@BurtHarris
Copy link

Yup, just had the same problem. You might consider removing the mention of winget from
/windows.md

PS: Thanks, scrcpy sounds like just what I was looking for.

@headquarter8302
Copy link
Contributor Author

Upstream solution available in Winget 1.9 clients

microsoft/winget-pkgs#107858 (comment)

@aisgbnok
Copy link

aisgbnok commented Dec 18, 2024

This has been fixed for all versions of the Genymobile.scrcpy package in microsoft/winget-pkgs, including the latest 3.1 release of scrcpy. scrcpy binaries (dlls, etc.) are now properly added to path winget. This issue can be closed.

@rom1v rom1v closed this as completed Dec 18, 2024
headquarter8302 added a commit to headquarter8302/scrcpy that referenced this issue Dec 19, 2024
rom1v pushed a commit that referenced this issue Dec 19, 2024
Semantically reverts c27ab46.

WinGet package has been fixed by:
<microsoft/winget-pkgs#196442>

Refs #4027 <#4027>
PR #5686 <#5686>

Signed-off-by: Romain Vimont <[email protected]>
rom1v pushed a commit that referenced this issue Dec 19, 2024
This semantically reverts c27ab46.

WinGet package has been fixed by:
<microsoft/winget-pkgs#196442>

Refs #4027 <#4027>
PR #5686 <#5686>

Signed-off-by: Romain Vimont <[email protected]>
yume-chan pushed a commit to yume-chan/scrcpy that referenced this issue Dec 22, 2024
This semantically reverts c27ab46.

WinGet package has been fixed by:
<microsoft/winget-pkgs#196442>

Refs Genymobile#4027 <Genymobile#4027>
PR Genymobile#5686 <Genymobile#5686>

Signed-off-by: Romain Vimont <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants