-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the new uid
option
#3729
Comments
I renamed from (I want to keep the name short, because on some devices app_process segfaults when the total command length exceeds 256)
Oh, great 👍 I see that you are doing a lot of R&D work, that's awesome 👍 (I'm still working on audio integration, I'm refactoring a lot of things in scrcpy to handle it properly.) Do you work on it in the context of |
ya-webadb is my personal open-source side project, which starts at an experiment of WebUSB API. Before that, I had very little experience on C, Java and Android. I wouldn't say my works on Scrcpy is "for" or "in the context of" that project. I knew and used Scrcpy way before starting ya-webadb. Integration of Scrcpy in ya-webadb is simply because Scrcpy is the best application I know that uses ADB and Android Shell permission. |
Thank you for your work anyway, very useful! 👍 |
dev
branch has a new option calleduid
, for differentiating multiple running Scrcpy instances. IMO it should not be calleduid
, becauseuid
is a common Linux concept, which might be useful in other cases.For example, with this little change, I can create a secure display on rooted Android 12+ devices (tested in an emulator):
https://github.com/Genymobile/scrcpy/compare/dev...yume-chan:scrcpy:feat/secure-display?expand=1
Unrooted:
Rooted:
Use
setUid(2000)
instead of1000
can fix issues like #1606So, the new option should be renamed, the new name can be
instance_id
or other more descriptive names.The text was updated successfully, but these errors were encountered: