Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In version 1.25, the screen does not resize in real time when you manually resize the window, but automatically resize when you release the mouse! #3640

Closed
Helaer opened this issue Dec 26, 2022 · 14 comments

Comments

@Helaer
Copy link

Helaer commented Dec 26, 2022

@rom1v In version 1.25, when you manually resize the window, the phone screen does not resize with the window, only when the mouse is released.

My computer is windows10 system.

@rom1v
Copy link
Collaborator

rom1v commented Dec 26, 2022

Oh, it's due to 18082f6 (I removed the workaround for Windows because it didn't work.

I'm surprised that it worked for you before. See #3458

@Helaer
Copy link
Author

Helaer commented Dec 26, 2022

哦,这是由于 18082f6(我删除了 Windows 的解决方法,因为它不起作用。

我很惊讶它以前对你有用。参见 #3458

Now, not only will the picture pause when dragging, but also the picture will tear when adjusting

rom1v added a commit that referenced this issue Dec 26, 2022
This reverts commit 18082f6.

I can't reproduce, but it seems the workaround improves the behavior on
some Windows versions.

Fixes #3640 <#3640>
Refs #3458 <#3458>
@rom1v
Copy link
Collaborator

rom1v commented Dec 26, 2022

Please confirm that it works again with d8c2fe6 on dev branch.

@Helaer
Copy link
Author

Helaer commented Dec 26, 2022

请确认它再次适用于分支上的 d8c2fe6dev

Sorry, I won't compile it into an exe file. Could you help me compile one

@Helaer
Copy link
Author

Helaer commented Dec 26, 2022

@rom1v It should be OK to restore it. I hope you can release a patch version. For users, the tear caused by the adjustment is very unpleasant.

@rom1v
Copy link
Collaborator

rom1v commented Dec 26, 2022

Here is a win64 binary:

  • scrcpy.exe SHA-256: c4f4a0e06870832634957aa6117665887c74b10022b58c5a9744ee00cdfca1ec

@Helaer
Copy link
Author

Helaer commented Dec 26, 2022

Here is a win64 binary:

  • scrcpy.exe SHA-256: c4f4a0e06870832634957aa6117665887c74b10022b58c5a9744ee00cdfca1ec

@rom1v Perfect work. The screen will not tear when adjusting. I hope you can release a patch version.

@Helaer
Copy link
Author

Helaer commented Dec 28, 2022

@rom1v Didn't you test it? If you adjust the window from different directions on Windows 10, the screen will tear, but the patch version will not. I hope that the original adjustment method will not be deleted. Thank you.

@rom1v
Copy link
Collaborator

rom1v commented Dec 28, 2022

When I tested, the image was just frozen during resize or drag on both version. The workaround did nothing different on my Windows 10 test machine.

@rom1v
Copy link
Collaborator

rom1v commented Jan 9, 2023

Could you please post a video screen capture when you resize with scrcpy v1.25?

@Helaer
Copy link
Author

Helaer commented Jan 10, 2023

当您使用 scrcpy v1.25 调整大小时,您能否发布视频屏幕截图?

1673322853469.mpeg4.aac.mp4

@rom1v The old version does not have this problem, the screen will not tear when adjusting, and there will be no black screen, but the picture is paused.

@rom1v
Copy link
Collaborator

rom1v commented Jan 10, 2023

Thank you 👍

@Helaer
Copy link
Author

Helaer commented Feb 6, 2023

Thank you 👍

@rom1v Hopefully it will be incorporated into the development branch so that this issue can be fixed in the next release, thank you!

@rom1v
Copy link
Collaborator

rom1v commented Feb 6, 2023

It is already on dev branch: d8c2fe6

@rom1v rom1v closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants