Pinch zooming support #24

paour · 2018-03-10T00:57:22Z

The Android emulator uses right click and drag to simulate pinch zooming. An alternative would be ctrl-mouse wheel.

octopusknives · 2018-03-16T02:50:29Z

Pinch zooming with a touchscreen also doesn't work.

CodeAck · 2018-09-21T21:19:23Z

Pinch zooming support would be a great idea!
Ctrl+← and Ctrl+→ could be used since ↓↑ are taken by volume control.
Would be great for people with low/no motor ability in their hands.
(I can't move from the shoulders down and greatly appreciate what you've done with scrcpy)

jknut · 2019-02-18T19:40:24Z

It would be great to have the ability to pinch zoom. Another alternative could be using the mouse wheel.

Scrcpy is really great!

Pixelstudio · 2019-04-12T09:14:20Z

Would be great if this can be added!

apiemont · 2019-04-15T07:39:32Z

another vote for this feature

ToggoStar · 2019-04-30T13:21:17Z

+1! Scrcpy is awesome and this is the only feature missing for me!

Pixelstudio · 2019-08-22T07:35:01Z

Oeh i see some references to this pr, but i cannot find if this is implemented...
Any idea?

rom1v · 2019-10-10T20:04:38Z

Hi, I just implemented an experimentation, on branch virtualfinger.

While the Ctrl key is held, the first left-click adds an immobile "virtual finger" at this position.

Moving the mouse moves another cursor. The left click may be released and pressed as necessary to control the second finger.

Releasing Ctrl releases the virtual finger.

rom1v · 2019-10-10T20:45:30Z

A simpler (and maybe more intuitive) alternative could be to always put the "virtual finger" in the center of the screen, so that "unzooming" is more natural.

As a drawback, it would not be possible to zoom on a widget which takes only a portion of the screen (which is not in the center), but it may be worth it.

CodeAck · 2019-10-10T21:04:58Z

OK cool, so what do we have to do to try this virtualfinger?
Upgrade anything? I'm on a Mac

srevinsaju · 2019-10-11T04:54:39Z

Literally amazing, this fixes issue srevinsaju/guiscrcpy#2 on guiscrcpy as well

srevinsaju · 2019-10-12T08:57:28Z

@rom1v I am having problems with the virtualfinger branch,

INFO: scrcpy 1.10 <https://github.com/Genymobile/scrcpy>
/usr/local/share/scrcpy/scrcpy-server.jar: 1 file pushed. 1.1 MB/s (22546 bytes in 0.019s)
INFO: Initial texture: 720x1280
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] WARN: Unknown event type: -1
[server] ERROR: Exception on thread Thread[Thread-1,5,main]
java.lang.IllegalStateException: Buffer full, call next() to consume
        at com.genymobile.scrcpy.ControlMessageReader.readFrom(ControlMessageReader.java:35)
        at com.genymobile.scrcpy.DesktopConnection.receiveControlMessage(DesktopConnection.java:110)
        at com.genymobile.scrcpy.Controller.handleEvent(Controller.java:82)
        at com.genymobile.scrcpy.Controller.control(Controller.java:73)
        at com.genymobile.scrcpy.Server$1.run(Server.java:45)
        at java.lang.Thread.run(Thread.java:764)

Is it due to some installation problem, or some unhandled exception. Running Ubuntu 19.04 scrcpy v1.10 virtualfinger branch.
The mirroring and screen shots continue to work, but the mouse events are not passed not even single and normal click passed.

Sent from my Galaxy Note2 using FastHub

rom1v · 2019-10-12T08:58:54Z

You need to recompile the server too.

srevinsaju · 2019-10-12T09:11:42Z

Thanks, will check that way

srevinsaju · 2019-10-12T09:47:59Z

@rom1v, no hope, the same error again

What I did


meson x --buildtype release --strip -Db_lto=true
cd x
ninja
cd app
./scrcpy

Unfortunately, the same error comes up. Can't pass clicks as well

Sent from my Galaxy Note2 using FastHub

Pixelstudio · 2020-01-15T08:59:10Z

Hi, i have used the branch virtualfinger, that allowed me to simulate pinch-zoom.
However that branch is falling behind compared to the master, any idea if you would implement this in the master ?

rom1v · 2020-01-15T09:15:21Z

The problem is that it is not really usable without a visual feedback (to display which locations are actually clicked), and it requires some work do implement it. So I probably won't merge it without that. 😞

Pixelstudio · 2020-01-15T09:19:28Z

ah, that is to bad. scrcpy is really great and the one feature missing for me is the ability to send a pinch command. is it much to work bind for example ctrl + and ctrl - to send a simulated pinch ?

whaevr · 2020-02-13T22:07:47Z

The problem is that it is not really usable without a visual feedback (to display which locations are actually clicked)

would it be possible to hook into the same touch events that the os shows for finger inputs? For example I have the developer option "show touch location" turned on. This works for my finger but not when I click with scrcpy, can scrcpy "use" that same method of tapping the ui that would produce these visual aids people could just turn on in dev options?

Im guessing not

boorac · 2020-03-01T12:40:00Z

+1 definitely a great feature

ahmadshiddiq · 2020-04-21T14:40:40Z

i cant wait for this feature, for gaming this will be very helpful

quancayda · 2020-05-15T08:06:40Z

I'm still waiting for day by day this feature released. It's really helpful for any app/game need Zoom in/out by mouse.
Any update so far for this great feature?

Voyajer · 2020-08-01T18:46:34Z

Pinch zooming seems to be the only input feature missing from scrcpy. Hopefully it gets implemented because this is very nice software.

If Ctrl is hold when the left-click button is pressed, enable pinch-to-zoom to scale and rotate relative to the center of the screen. Fixes #24 <#24>

rom1v · 2020-08-09T15:05:58Z

Hi,

I finally worked on this feature today.

The problem with my previous attempts is that I wanted to be able to zoom from any point (not only the center of the screen), but it's a UX nightmare. Therefore, I took the same approach as the Android emulator, and just scale/rotate relative to the center of the screen. That way, it's easy to zoom/unzoom.

Just hold Ctrl when you lelf-click to enable pinch-to-zoom (it is disabled when left-click is released). (I used Ctrl because that's what the Android emulator does.)

The branch is pinch_zoom.

Here is a Windows binary to test (replace in your v1.15.1 release):

scrcpy.exe
SHA256: 1b38173837da14e5b134582ba75aa38e166903aaa592cb0b8b10d6ba8a1e61ce

rom1v · 2020-08-10T18:54:55Z

Implemented in v1.16.

elig0n · 2020-08-10T19:41:30Z

Anyone else experiencing problem with pinch-zooming maps? Currently experienced in both Google Maps and OSMand.
I seem to not be able to zoom out or in very much because at a certain point the action turns into its opposite, sometimes with the map rotating around itself a full round.
One must hold the mouse pointer at the very pinpoint accurate point where the pointer originally was pressed to be able to keep zooming out or in to farther lengths without turning the map around and/or reversing the zoom operation. For short-step zoom actions there is no such problem so long-step zooming can be achieved only via several, consecutive short-step zooming.

rom1v · 2020-08-10T19:47:14Z

Currently experienced in both Google Maps and OSMand.
I seem to not be able to zoom out or in very much because at a certain point the action turns into its opposite, sometimes with the map rotating around itself a full round.

To zoom out, you need to start at the edges (top, bottom, left or right) and moves towards the center.

Imagine that this mode adds a finger inverted through the center:

(This is a capture from Android emulator, unfortunately scrcpy does not provide any visual feedback, hence the confusion.)

elig0n · 2020-08-10T19:50:55Z

Would you reconsider to reverse the mouse drag directions actions ? i.e to make pulling the mouse towards me zoom out and pulling away from me zoom in ? or maybe the app would need at some point an INI-style configuration file for to reconfigure all the keys.

rom1v · 2020-08-10T19:54:38Z

i.e to make pulling the mouse towards me zoom out and pulling away from me zoom in ?

What do you mean by "pulling towards" or "pulling away"? The screen is 2D and you are in another dimension 😄

Would you reconsider to reverse the mouse drag directions actions ?

In fact, this feature does not implement "zoom in/out", nor choose any drag direction, it just injects additional touch events at a location inverted through the center of the screen. Then the Android app normally reacts to the touch events from the mouse and the virtual finger.

edulourenzo · 2020-08-18T17:25:47Z

Good afternoon.
I think the issue is not the zoom of the screen.
And yes, simulate the pinch movement.
An easy way would be:
When pressing a key (alt), two fingers are pressed, pressing the screen from a distance "R" from the mouse position captured with (x, y).
And depending on the scroll of the mouse, these fingers move apart or get closer to the mouse position.
I think the ideal would be diagonally as some photo editors stretch vertically or horizontally. And diagonally this would maintain the proportion.
So you pass the responsibility to the application. If he has zomm the app interacts with the fake fingers. Otherwise the application does nothing.
I think it would not be difficult to simulate the pinch and not the zoom, leave that to the application that is running.
It probably won't work for all cases, but I think it would be a solution for most.

rom1v · 2020-08-18T23:02:40Z

@edulourenzo Isn't more or less what is implemented in v1.16? (except it does not use the mouse scroll)

edulourenzo · 2020-08-19T10:59:40Z

And what would be the command to make the zoom pinch movement

rom1v · 2020-08-19T11:02:09Z

Ctrl+click-and-move.

More details: https://github.com/Genymobile/scrcpy/releases/tag/v1.16

ChristopherH · 2020-08-31T11:23:25Z

AWESOME! been waiting for this feature for a long time, i love scrcpy but it always lacked that one major feature, thanks alot to all developers, you are doing a terrific job!

alimsk · 2021-09-20T19:55:01Z

no longer working?
i'm on linux
android 10

rom1v · 2021-09-20T19:57:55Z

Yes, it is working: https://github.com/Genymobile/scrcpy#pinch-to-zoom

Which version of scrcpy do you use?

alimsk · 2021-09-20T19:59:18Z

i use

$ scrcpy --version
scrcpy 1.12.1

dependencies:
 - SDL 2.0.10
 - libavcodec 58.54.100
 - libavformat 58.29.100
 - libavutil 56.31.100

alimsk · 2021-09-20T21:33:56Z

i rebuild scrcpy from source code and it suddenly worked 😕

rom1v · 2021-09-20T21:35:18Z

scrcpy 1.12.1

It's a very old version, pinch zoom has been implemented in 1.16.

alimsk · 2021-09-20T21:36:45Z

i installed it with apt install scrcpy.
anyways thank you

rom1v added the feature request label Mar 10, 2018

This was referenced Aug 1, 2019

Features implemented in a fork #679

Open

Use Cmd instead of Ctrl on macOS #676

Merged

rom1v mentioned this issue Aug 27, 2019

"pull from" mouse gesture #668

Open

rom1v mentioned this issue Mar 30, 2020

About double fingers control on scrcpy #1252

Closed

rom1v mentioned this issue Apr 21, 2020

[Request for tests] Refactor rendering and events position/scaling #1307

Closed

rom1v mentioned this issue May 18, 2020

Rendering rework #1408

Closed

ANDImur mentioned this issue Jun 25, 2020

Can't run scrcpy; Error 0xfffffc03 #1525

Open

rom1v added a commit that referenced this issue Aug 9, 2020

Add pinch-to-zoom simulation

eff5036

If Ctrl is hold when the left-click button is pressed, enable pinch-to-zoom to scale and rotate relative to the center of the screen. Fixes #24 <#24>

rom1v mentioned this issue Aug 10, 2020

The Ctrl+V function of version 1.15.1 has no effect on some devices. #1658

Closed

rom1v closed this as completed in 198346d Aug 10, 2020

rom1v mentioned this issue Feb 14, 2021

[New Feature Request] Zoom Slider on top of Scrcpy window, next to device name #2119

Open

Pinch zooming support #24

Pinch zooming support #24

Comments

paour commented Mar 10, 2018

octopusknives commented Mar 16, 2018

CodeAck commented Sep 21, 2018

jknut commented Feb 18, 2019

Pixelstudio commented Apr 12, 2019

apiemont commented Apr 15, 2019

ToggoStar commented Apr 30, 2019

Pixelstudio commented Aug 22, 2019

rom1v commented Oct 10, 2019

rom1v commented Oct 10, 2019

CodeAck commented Oct 10, 2019 • edited Loading

srevinsaju commented Oct 11, 2019 via email • edited Loading

srevinsaju commented Oct 12, 2019 • edited Loading

rom1v commented Oct 12, 2019

srevinsaju commented Oct 12, 2019

srevinsaju commented Oct 12, 2019 • edited Loading

Pixelstudio commented Jan 15, 2020

rom1v commented Jan 15, 2020

Pixelstudio commented Jan 15, 2020

whaevr commented Feb 13, 2020

boorac commented Mar 1, 2020

ahmadshiddiq commented Apr 21, 2020

quancayda commented May 15, 2020

Voyajer commented Aug 1, 2020

rom1v commented Aug 9, 2020

rom1v commented Aug 10, 2020

elig0n commented Aug 10, 2020 • edited Loading

rom1v commented Aug 10, 2020

elig0n commented Aug 10, 2020

rom1v commented Aug 10, 2020 • edited Loading

edulourenzo commented Aug 18, 2020

rom1v commented Aug 18, 2020

edulourenzo commented Aug 19, 2020

rom1v commented Aug 19, 2020

ChristopherH commented Aug 31, 2020 • edited Loading

alimsk commented Sep 20, 2021 • edited Loading

rom1v commented Sep 20, 2021

alimsk commented Sep 20, 2021

alimsk commented Sep 20, 2021

rom1v commented Sep 20, 2021

alimsk commented Sep 20, 2021

CodeAck commented Oct 10, 2019 •

edited

Loading

srevinsaju commented Oct 11, 2019 via email •

edited

Loading

srevinsaju commented Oct 12, 2019 •

edited

Loading

srevinsaju commented Oct 12, 2019 •

edited

Loading

elig0n commented Aug 10, 2020 •

edited

Loading

rom1v commented Aug 10, 2020 •

edited

Loading

ChristopherH commented Aug 31, 2020 •

edited

Loading

alimsk commented Sep 20, 2021 •

edited

Loading