-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility of expanding the (0;65535) interval, support larger display id? #2009
Comments
Please test |
Wow, that's pretty swift of you! I was wrong about the error tracing. |
See discussion #1238. |
OK, cool, merged into |
Actually, I had this warning all along, and I didn't care because if you don't have it, you don't have it, right? |
Is your feature request related to a problem? Please describe.
My cellphone is Smartisan Pro 3, which is a Chinese brand comes with a desktop mode named TNT(Touch & Talk), so think of it as Samsung DeX. For some time, I was able to use TNT on my PC with '--display' option. After a recent update, they changed the display id of desktop image feeding to adb, starting from 100001:
Clearly Scrcpy doesn't support the oversized display id, it gives a out-of-range(0;65535) error:
I did some hacking to cli.c, make Scrcpy accept the display id:
But nope, the error pointed directly down to Android internal:
34468 looks like a variable overflow(=100004-65536), but I don't know where it happened.
All in all, this feels serious... and beyond my capability.
Describe the solution you'd like
Is it possible to enlarge the display id range? Do we have to make some change to Android code?
Describe alternatives you've considered
Nothing at all, if it is not quite possible I understand. We are not even clear if Smartisan's action is a violation of Android guidelines or did they made the change on purpose just to block Scrcpy.
Additional context
TNT is a pretty potential OS. I'm sure there is a group of people hoping to use it on PC again. And maybe, just maybe, Smartisan is making an application like Samsung Dex to support it. Before that, Scrcpy seems to be our only option.
The text was updated successfully, but these errors were encountered: