-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When the screen is off, if the screen turns on from a command in the PC, order it to turn back off #1573
Comments
This is related to #1572, right?
You can't know, the user could press the physical power button for example. Trying to work around the Android behavior, which is to reset the power mode to NORMAL when pressing the power button, with time-based heuristics looks very hacky/unreliable to me. Ref: #618 (comment) |
That is a problem outside the scope of this issue.
I think so too. I want to try finding something that doesn't look hacky like that. |
I just noticed the first part in this issue is the same as the other one. I think this was the automatic draft saving from the other issue and I was blinded from seeing it properly. I removed that part now. |
@rom1v Do you know any way to know whether the screen is on or off? |
Fixes #1573 <#1573> PR #1577 <#1577> Signed-off-by: Romain Vimont <[email protected]>
PR #1577 <#1577> Fixes #1573 <#1573> Signed-off-by: Romain Vimont <[email protected]>
Merged cf9d449 |
Is your feature request related to a problem? Please describe.
Sometimes I get distracted by my phone when the screen turns back on and I'm working on it.
I have attention problems from flashing lights and moving things which atract me too much and the phone screen turning on and me having to act because of that is part of an issue to me.
Describe the solution you'd like
1.1
Ctrl+o
or--screen-off
(command line option) is more recent thanCtrl+Shift+o
1.2. A command is sent to the phone, through
scrcpy
that is known to turn the screen on.1.3. The screen tries to turn on in the following X (maybe 5) seconds.
1.3.1. 1.1. is still true
---> Turn the screen back off ASAP
Describe alternatives you've considered
I tried to use an automation tool that detects right clicks and
Ctrl+p
on the desktop app but it works like a terrible hack. Sometimes the command goes too early, other times the second command is mixed together with something else I'm trying to do.In those cases, I have already ended up giving orders for things I didn't mean to.
Extra:
I intent to implement this myself. It can also allow me to familiarize with these workings of android.
This issue is to confirm if I have green light for such feature in scrcpy
The text was updated successfully, but these errors were encountered: