Skip to content

Commit

Permalink
Do not report workarounds errors
Browse files Browse the repository at this point in the history
Some workarounds are needed on some devices. But applying them may cause
exceptions on other devices, where they are not necessary anyway.

Do not report these errors in release builds.

Closes #994 <#994>
  • Loading branch information
rom1v committed Jan 19, 2020
1 parent dc7fcf3 commit 96bd2c9
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public static void fillAppInfo() {
mInitialApplicationField.set(activityThread, app);
} catch (Throwable throwable) {
// this is a workaround, so failing is not an error
Ln.w("Could not fill app info: " + throwable.getMessage());
Ln.d("Could not fill app info: " + throwable.getMessage());
}
}
}

2 comments on commit 96bd2c9

@hafizidev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit should be on the release branch instead of dev. Dev should keep with w tag if that's mean warning logs, because on the development, we need all logs we can get, including warnings, but in the release version those warning can be ignored until it becomes a problem for user and can investigate further by running a development version.

@rom1v
Copy link
Collaborator Author

@rom1v rom1v commented on 96bd2c9 Jan 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev is the development branch, containing commits for the next release.

Please sign in to comment.