Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIxS should have a single term for any one concern (door types vs door materials) #893

Open
turbomam opened this issue Jan 28, 2025 · 2 comments

Comments

@turbomam
Copy link
Member

turbomam commented Jan 28, 2025

MIxS has a lot of terms about doors (and ceilings) and it seems like there is a lot of overlap or redundancy. That adds to our maintenance cost and decreases the clarity to data contributors or data users who want to find samples that are characterized by a particular kind of door.

MIxS term description
door area or size (door_size) The size of the door
door condition (door_cond) The phsical condition of the door
door direction of opening (door_direct) The direction the door opens
door location (door_loc) The relative location of the door in the room
door material (door_mat) The material the door is composed of
door movement (door_move) The type of movement of the door
door signs of water/mold (door_water_mold) Signs of the presence of mold or mildew on a door
door type (door_type) The type of door material
door type, composite (door_comp_type) The composite type of the door
door type, metal (door_type_metal) The type of metal door
door type, wood (door_type_wood) The type of wood door

I don't see any evidence that any of those have been used in NCBI Biosample records

How can I determine who added these terms and what their maintenance expectations are? Searches liek this don't seem to help: https://github.com/search?q=org%3AGenomicsStandardsConsortium+door_type&type=code

See the next two issue comments for

see also

@turbomam
Copy link
Member Author

DoorCompTypeEnum

  • metal covered
  • revolving
  • sliding
  • telescopic

DoorDirectEnum

  • inward
  • outward
  • sideways

DoorMatEnum

  • aluminum
  • cellular PVC
  • engineered plastic
  • fiberboard
  • fiberglass
  • metal
  • thermoplastic alloy
  • vinyl
  • wood
  • wood/plastic composite

DoorMoveEnum

  • collapsible
  • folding
  • revolving
  • rolling shutter
  • sliding
  • swinging

DoorTypeEnum

  • composite
  • metal
  • wooden

DoorTypeMetalEnum

  • collapsible
  • corrugated steel
  • hollow
  • rolling shutters
  • steel plate

@turbomam
Copy link
Member Author

turbomam commented Jan 28, 2025

From ChatGPT 4o

Overlap Across Enumerations

  1. Material (Composition):

    • DoorMatEnum (e.g., metal, wood, fiberglass) and DoorTypeEnum (e.g., metal, wooden) partially overlap in describing door materials. However, DoorMatEnum is more granular, listing specific materials (e.g., aluminum, fiberglass), while DoorTypeEnum is more categorical.
  2. Motion or Movement:

    • DoorCompTypeEnum and DoorMoveEnum share terms like "sliding" and "revolving," indicating overlap in describing how doors operate or move.
    • DoorMoveEnum and DoorTypeMetalEnum overlap in describing specific types of metal doors that move (e.g., collapsible, rolling shutters).
  3. Specific Types:

    • DoorTypeEnum (e.g., metal, wooden) and DoorMatEnum both refer to door materials, but DoorMatEnum is more detailed.
    • DoorTypeMetalEnum overlaps with DoorTypeEnum in focusing on metal doors but provides additional details (e.g., corrugated steel, rolling shutters).

Key Differences

  1. Focus:

    • DoorCompTypeEnum focuses on the design or structure of doors (e.g., sliding, telescopic).
    • DoorDirectEnum exclusively describes door direction (e.g., inward, outward).
    • DoorMatEnum and DoorTypeEnum focus on the materials used.
    • DoorMoveEnum and DoorTypeMetalEnum focus on the mechanical behavior or specialized types of doors.
  2. Granularity:

    • DoorMatEnum is the most detailed in describing materials, compared to DoorTypeEnum, which is higher-level.
    • DoorTypeMetalEnum is a detailed subset of metal doors, providing specific variations not found in other enumerations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant