Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common alias coltypes (-f) for specifying i/o data types #994

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Mar 3, 2021

Description of proposed changes

Used to specify data types of input and/or output columns (time or geographical data). See also:

Preview at https://pygmt-git-common-aliases-coltypes-gmt.vercel.app/api/generated/pygmt.Figure.basemap.html

Needed for the workaround datetime bugfix at #960

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 added the documentation Improvements or additions to documentation label Mar 3, 2021
@weiji14 weiji14 added this to the 0.3.1 milestone Mar 3, 2021
@seisman
Copy link
Member

seisman commented Mar 3, 2021

@PaulWessel Does grdcut have the -f option? The grdcut documentation says yes, but the grdcut.c doesn't list it in THIS_MODULE_OPTIONS.

#define THIS_MODULE_OPTIONS "-JRV"

A GMT bug?

@PaulWessel
Copy link
Member

Yes, I think so. Please make a PR that adds it in. I think it just needs adding to THIS_MODULE_OPTIONS since already present in synopsis and usage.

seisman added a commit to GenericMappingTools/gmt that referenced this pull request Mar 3, 2021
seisman added a commit to GenericMappingTools/gmt that referenced this pull request Mar 3, 2021
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge, although grdcut doesn't support -f in GMT 6.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants