-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gallery example showing different polar projection use cases #955
Conversation
FYI, GMT will support multi-line title and also subtitle in the upcoming 6.2.0 version (see GenericMappingTools/gmt#4562 for how it works). Currently, I don't know other better ways to add multi-line texts. |
Perhaps easier to put texts in the middle of the figure if you use the |
Thanks for this, however, it does not work for all examples equally well. |
Sorry, my previous comment is misleading. I meant the
|
Works better but there are still some issues:
|
I think it's caused by how we pass arguments to GMT API, similar to #247.
Related to GenericMappingTools/gmt#576. The main reason is that GMT may think "+t" is an option modifier, not part of a long string. |
If you change |
Thanks @seisman ! |
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GenericMappingTools/python @GenericMappingTools/python-maintainers
This gallery example looks good to me. Please give it a second-round review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Given how detailed this gallery example is and that it contains all the information presented in the gallery example titled 'Polar', I think it would be more clear if it were the only polar non-geographic projection example and the other example were removed. The title for this example could then simply be 'Polar' for consistency with the other projection examples.
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Would be fine for me. Any other comments on this? |
Sounds good. |
Committed the proposed changes. |
Thanks for the careful and detailed review @seisman and @meghanrjones . |
…ericMappingTools#955) Co-authored-by: Dongdong Tian <[email protected]> Co-authored-by: Meghan Jones <[email protected]>
As mentioned in #942 here's a gallery example showing different ways how the polar projection (-JP) can be used. The example is heavily based on the GMT Chinese documentation.
I would prefer a short discussion about how the parameter descriptions for
projection
andregion
should be inlcuded in the figure @GenericMappingTools/python-contributors @GenericMappingTools/python-maintainers. So far I added simple text and adjusted manually since the title option does not support titles with line breaks (as far as I know). Documentation is also missing so far but I will add it after the aforementioned discussion.Reminders
make format
andmake check
to make sure the code follows the style guide.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version