-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog entry for v0.3.0 #887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @willschlitzer, assuming that you're learning from the previous release PR at #683 already. if you don't mind, could you edit the top post to follow that style (with checkboxes and all). We'll probably turn it into a proper template for #885 next time.
Oh and by the way, I see that you've cleaned up the draft release notes at https://github.com/GenericMappingTools/pygmt/releases. Make sure you have a local backup, otherwise the release drafter bot will override your changes when we merge the last few PRs remaining for v0.3.0. |
@weiji14 It's backed up! |
Co-authored-by: Dongdong Tian <[email protected]>
doc/changes.rst
Outdated
|
||
Highlights | ||
|
||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to add 3 to 4 lines for the highlights section here. How about:
* | |
* 🎉 **Third minor release of PyGMT** 🎉 | |
* Wrap inset (#788) for making overview maps and subplot (#822) for multi-panel figures | |
* Apply standardized formatting conventions (#775) across most documentation pages | |
* Drop Python 3.6 support (#699) so PyGMT now requires Python 3.7 or newer |
Feel free to suggest edits in the wording. I'm also thinking whether to mention the upcoming drop in support for GMT 6.1.1 (once GMT 6.2.0 is out, something for PyGMT v0.4.0) and/or NEP29 adoption (#690). Might depend on whether we want a v0.3.1 release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also thinking whether to mention the upcoming drop in support for GMT 6.1.1 (once GMT 6.2.0 is out, something for PyGMT v0.4.0) and/or NEP29 adoption
Don't try to predict the future. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will surprise our users then 😸
doc/changes.rst
Outdated
|
||
Contributors | ||
|
||
@liamtoney, @meghanrjones, @michaelgrund, @seisman, @weiji14 and @willschlitzer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liamtoney, @meghanrjones, @michaelgrund, @seisman, @weiji14 and @willschlitzer | |
People with a "+" by their name contributed a patch for the first time. | |
* `Dongdong Tian <https://github.com/seisman>`__ | |
* `Liam Toney <https://github.com/liamtoney>`__ | |
* `Meghan Jones <https://github.com/meghanrjones>`__ + | |
* `Michael Grund <https://github.com/michaelgrund>`__ + | |
* `Wei Ji Leong <https://github.com/weiji14>`__ | |
* `Will Schlitzer <https://github.com/willschlitzer>`__ + |
Two thoughts here:
- Should we sort alphebetically by name (as above), or by number of commits (old style before).
- Some projects (e.g. geopandas) add a little note with a plus (+) to indicate people's first contribution, should we add it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two thoughts here:
- Should we sort alphebetically by name (as above), or by number of commits (old style before).
I'm fine with both, but prefer "number of commits".
- Some projects (e.g. geopandas) add a little note with a plus (+) to indicate people's first contribution, should we add it here?
I saw it in many projects, but is there an easy way to know if someone makes his/her first contribution to this release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Some projects (e.g. geopandas) add a little note with a plus (+) to indicate people's first contribution, should we add it here?
I saw it in many projects, but is there an easy way to know if someone makes his/her first contribution to this release?
Other than remembering people, there's probably a complicated git command that could do it. Happy to leave it without the plus.
I'm fine with both, but prefer "number of commits".
I thought your name would be on top either way, but git shortlog HEAD...v0.2.1 -sne
gives:
58 Will Schlitzer <[email protected]>
54 Dongdong Tian <[email protected]>
9 Wei Ji <[email protected]>
7 Michael Grund <[email protected]>
6 dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
3 Liam Toney <[email protected]>
3 Meghan Jones <[email protected]>
3 Wei Ji <[email protected]>
and so the order would be:
@liamtoney, @meghanrjones, @michaelgrund, @seisman, @weiji14 and @willschlitzer | |
* `Will Schlitzer <https://github.com/willschlitzer>`__ | |
* `Dongdong Tian <https://github.com/seisman>`__ | |
* `Wei Ji Leong <https://github.com/weiji14>`__ | |
* `Michael Grund <https://github.com/michaelgrund>`__ | |
* `Liam Toney <https://github.com/liamtoney>`__ | |
* `Meghan Jones <https://github.com/meghanrjones>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I'll commit the change, but we should document this (order by number of commits) for when we deal with #885.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running git shortlog HEAD...v0.2.1 -sne
on the master branch gives me:
54 Dongdong Tian <[email protected]>
54 Will Schlitzer <[email protected]>
9 Wei Ji <[email protected]>
7 Michael Grund <[email protected]>
6 dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
3 Liam Toney <[email protected]>
3 Meghan Jones <[email protected]>
Not trying to be listed at the top, just curious why our results are different 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I was probably on a different branch (which explains why it had my unversity vuw.ac.nz email). I think you'll get bumped down after @willschlitzer merges this PR though 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dare I suggest that as a GMT developer and long-time PyGMT maintainer, I think @seisman has definitely earned the first spot!
Co-authored-by: Dongdong Tian <[email protected]>
Also, are you able to run |
Forgot about that one! Just ran it and pushed the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, noticed a few more missing stuff at https://pygmt-git-v030-release.gmt.vercel.app/changes.html#release-v0-3-0-2021-02-15.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, manually updating two lines for now to be comma (,) separated, because I can't be bothered to learn sed
in a rush. Hopefully this is the last 🤞
Co-authored-by: Wei Ji <[email protected]>
Hoping for that too! |
Third minor release of PyGMT. * Add v0.3.0 to version_switch.js * Update citation information * Update compatibility and documentation links * Initial draft changelog from Release Drafter * Merge some changelog entries together * Add highlights and list out contributor names ordered by no. of commits * Group changes in the "Maintenance" section * Group changes in the 'Documentation' section and update some titles * Run sed command to format links; format fixes Co-authored-by: Wei Ji <[email protected]> Co-authored-by: Dongdong Tian <[email protected]> Co-authored-by: Will Schlitzer <[email protected]>
Third minor release of PyGMT. * Add v0.3.0 to version_switch.js * Update citation information * Update compatibility and documentation links * Initial draft changelog from Release Drafter * Merge some changelog entries together * Add highlights and list out contributor names ordered by no. of commits * Group changes in the "Maintenance" section * Group changes in the 'Documentation' section and update some titles * Run sed command to format links; format fixes Co-authored-by: Wei Ji <[email protected]> Co-authored-by: Dongdong Tian <[email protected]> Co-authored-by: Will Schlitzer <[email protected]>
Third minor release of PyGMT. * Add v0.3.0 to version_switch.js * Update citation information * Update compatibility and documentation links * Initial draft changelog from Release Drafter * Merge some changelog entries together * Add highlights and list out contributor names ordered by no. of commits * Group changes in the "Maintenance" section * Group changes in the 'Documentation' section and update some titles * Run sed command to format links; format fixes Co-authored-by: Wei Ji <[email protected]> Co-authored-by: Dongdong Tian <[email protected]> Co-authored-by: Will Schlitzer <[email protected]>
Description of proposed changes
Preview: https://pygmt-git-v030-release.gmt.vercel.app/changes.html
Previous release at #683
Changelog made by following the instructions at https://github.com/GenericMappingTools/pygmt/blob/master/MAINTENANCE.md#updating-the-changelog. The changelog itself includes the following sections:
TODO:
sed -i.bak -E 's$\(#([0-9]*)\)$(`#\1 <https://github.com/GenericMappingTools/pygmt/pull/\1>`__)$g' changes.rst
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version