Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test file for draft pull requests #869

Closed
wants to merge 2 commits into from

Conversation

willschlitzer
Copy link
Contributor

As discussed in #584, this is a change of the .yaml files to create a test for draft pull requests. In a draft, the tests only run Python 3.9 on Ubuntu-latest. The entire test suite for different operating systems and Python versions only runs when the pull request is marked ready for review.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer
Copy link
Contributor Author

willschlitzer commented Feb 12, 2021

@seisman @weiji14 I think I did this correctly and modified the appropriate .yaml files, but I'm not sure how to test it.

EDIT: Nevermind, it appears that none of the CI tests are running.

@seisman
Copy link
Member

seisman commented Feb 12, 2021

In a draft, the tests only run Python 3.9 on Ubuntu-latest.

I can't say I like this.

@willschlitzer
Copy link
Contributor Author

In a draft, the tests only run Python 3.9 on Ubuntu-latest.

I can't say I like this.

Would you recommend something differently, or not reducing the tests at all for drafts? My thought is that ubuntu typically runs the fastest, and this will provide a check on all the tests without requiring so many CI jobs for ever minor change, but still running the gamut of tests when the PR is marked ready for review.

@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Feb 14, 2021
@seisman seisman closed this in #906 Feb 16, 2021
@seisman seisman added this to the 0.4.0 milestone Feb 16, 2021
@seisman
Copy link
Member

seisman commented Feb 16, 2021

@willschlitzer See #906 for the better implementation and don't forget to push the "Delete branch" button if you no longer need it.

@seisman seisman modified the milestones: 0.4.0, 0.3.1 Feb 16, 2021
@seisman seisman deleted the pr-draft-test-suite branch March 14, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants