-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add affiliation and ORCID to AUTHORS.md #857
Conversation
Ping @michaelgrund, @weiji14, @tjnewton, @leouieda |
Co-authored-by: Dongdong Tian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @liamtoney for making this PR! Just a few comments:
- Maybe have ORCID before the Affiliation, since not everyone has an affiliation (and it's also less stable since people move around institutions) but ORCID should be available to everyone.
- Do we want the affiliation to be the full Department, University, City, Country format? I understand that the full affiliation would be needed for a paper, but again, a lot can happen between now and the paper coming out. Right now it's only the University name listed on Zenodo (hover over the names at https://zenodo.org/record/4253459).
AUTHORS.md
Outdated
@@ -8,10 +8,10 @@ Manoa. | |||
The following people have contributed code to the project (alphabetical by last name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following people have contributed code to the project (alphabetical by last name) | |
The following people have contributed code to the project (alphabetical by name) |
As per our Code of Conduct to be inclusive, I think we should just sort alphabetically by name (i.e. full name) for these reasons:
- Some people don't have family names (see e.g. Indonesian names). Also, 'last' name isn't applicable to every culture. My last name is "Leong" for example, but it's technically positioned "first" from where I grew up, and we've always just used "name" rather than "first name" "last name".
- People who get married and change their last name will keep their alphabetical position in the list (unless their last name is positioned first 🙃).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point @weiji14. Let's do it.
Co-authored-by: Wei Ji <[email protected]>
This makes sense. I'll update.
Is the motivation to update this less often? We could forgo affiliations here and just ask for them when making releases or just when writing papers? |
Thanks for the ping. Do the instructions linked below look correct for adding my changes to this PR? I bungled my first attempt. https://tighten.co/blog/adding-commits-to-a-pull-request/ |
Just want to notify @carocamargo, @mjziebarth, and @akshmakov of this PR, in case they want to take the opportunity to add themselves to the author list for their wrapping of grdfilter, contour, and grdcontour respectively. |
I'm OK with the changes. I think we also need to update the descriptions in the
|
Co-authored-by: Meghan Jones <[email protected]>
Also updated wrapping of some sentences in AUTHORSHIP.md Co-Authored-By: Dongdong Tian <[email protected]>
Thanks for fixing my commit weirdness! |
Co-authored-by: Wei Ji <[email protected]>
@meghanrjones Not sure if you are planning on adding your name to AUTHORS.md, but if so, please do so today. |
Co-authored-by: Meghan Jones <[email protected]>
Hi @meghanrjones, I just merged this PR into master. Feel free to add yourself to AUTHORS.md in a separate PR if you're willing to do. |
@seisman and @willschlitzer, thanks for the invitation. I won't be able to get a new PR in today. If you need my ORCID for anything else and want to include me, it's 0000-0003-0180-8928. But, I really don't mind waiting until after v0.3.0 gets released to add myself here. I'll plan to submit a PR on Tuesday after the rush of the release is over. |
* Add affiliation and ORCID for Liam * Add Will Schlitzer ORCID * Add Dongdong Tian ORCID * Add Michael Grund ORCID * Clarify what should be added to AUTHORS.md * Add Malte Ziebarth to AUTHORS.md * Add Wei Ji ORCID and affiliation * Add Tyler Newton ORCHID & affiliation (GenericMappingTools#880) Co-authored-by: Dongdong Tian <[email protected]> Co-authored-by: Wei Ji <[email protected]> Co-authored-by: Meghan Jones <[email protected]> Co-authored-by: Malte Ziebarth <[email protected]> Co-authored-by: Will Schlitzer <[email protected]> Co-authored-by: Michael Grund <[email protected]> Co-authored-by: Tyler Newton <[email protected]>
Description of proposed changes
Add affiliation and ORCID to
AUTHORS.md
, in light of #726. Others can jump on this PR to add their info too.