-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the error message when PyGMT fails to load the GMT library #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When PyGMT fails to load the GMT library, it raises an error: ``` GMTCLibNotFoundError: Error loading the GMT shared library '/opt/GMT-6.1.1/lib/libgmt.dylib'. ``` However, it's still unclear why it fails. After this PR, the error message will contain the original error message. For example: ``` GMTCLibNotFoundError: Error loading the GMT shared library '/opt/GMT-6.1.1/lib/libgmt.dylib'. dlopen(/opt/GMT-6.1.1/lib/libgmt.dylib, 6): Library not loaded: @rpath/libnetcdf.15.dylib Referenced from: /opt/GMT-6.1.1/lib/libgmt.6.1.1.dylib Reason: image not found. ```
weiji14
reviewed
Jan 29, 2021
Co-authored-by: Wei Ji <[email protected]>
/format |
weiji14
approved these changes
Jan 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (sorry about the Syntax Error!). I'll leave it up to you to decide whether to add the skip-changelog
tag. Once this is done, we should look at finalizing #702 too.
seisman
changed the title
Display the original error message if failing to load the GMT library
Improve the error message when PyGMT fails to load the GMT library
Jan 30, 2021
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…enericMappingTools#814) When PyGMT fails to load the GMT library, it raises an error: ``` GMTCLibNotFoundError: Error loading the GMT shared library '/opt/GMT-6.1.1/lib/libgmt.dylib'. ``` However, it's still unclear why it fails. After this PR, the error message will contain the original error message. For example: ``` GMTCLibNotFoundError: Error loading the GMT shared library '/opt/GMT-6.1.1/lib/libgmt.dylib'. dlopen(/opt/GMT-6.1.1/lib/libgmt.dylib, 6): Library not loaded: @rpath/libnetcdf.15.dylib Referenced from: /opt/GMT-6.1.1/lib/libgmt.6.1.1.dylib Reason: image not found. ``` Co-authored-by: Wei Ji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
When PyGMT fails to load the GMT library, it raises an error:
However, it's still unclear why it fails.
After this PR, the error message will contain the original error
message. For example:
Fixes #792.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Notes
/format
in the first line of a comment to lint the code automatically