Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for grdfilter #809

Merged
merged 16 commits into from
Jan 30, 2021
Merged

Add tests for grdfilter #809

merged 16 commits into from
Jan 30, 2021

Conversation

willschlitzer
Copy link
Contributor

@willschlitzer willschlitzer commented Jan 28, 2021 •
edited
Loading

This pull request adds tests for the grdfilter function in grdops.py.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.

Notes

  • You can write /format in the first line of a comment to lint the code automatically

@willschlitzer willschlitzer added the maintenance Boring but important stuff for the core devs label Jan 28, 2021
@willschlitzer willschlitzer added this to the 0.3.0 milestone Jan 28, 2021
@willschlitzer willschlitzer marked this pull request as ready for review January 28, 2021 10:11
@seisman
Copy link
Member

seisman commented Jan 28, 2021

@willschlitzer Just a quick comment. When opening a PR, please use the PR template, so we can have the PR checklist.

@willschlitzer
Copy link
Contributor Author

@seisman Sorry about that.

@seisman
Copy link
Member

seisman commented Jan 28, 2021

It would be better if you can add two more checks:

  • grid file in, grid file out
  • grid file in, xr.DataArray out.

@willschlitzer
Copy link
Contributor Author

@seisman Added the two additional tests.

seisman
seisman approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me.

I'll keep this PR unmerged for two more days so that @GenericMappingTools/python @GenericMappingTools/python-maintainers can give it a final review.

@seisman seisman changed the title Add grdfilter tests Add tests for grdfilter Jan 28, 2021
weiji14
weiji14 approved these changes Jan 30, 2021
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@seisman seisman merged commit a828f73 into GenericMappingTools:master Jan 30, 2021
@weiji14 weiji14 mentioned this pull request Apr 22, 2021
Merged
5 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@willschlitzer @seisman
Add tests for grdfilter (GenericMappingTools#809)
74b956e 
Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

@seisman seisman seisman approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@willschlitzer @seisman @weiji14