Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dcw alias (E) to Figure.coast #765

Merged
merged 31 commits into from
Jan 18, 2021
Merged

Add dcw alias (E) to Figure.coast #765

merged 31 commits into from
Jan 18, 2021

Conversation

willschlitzer
Copy link
Contributor

Add paint_country as an alias for the -E parameter for Figure.coast. Add tests for the new parameter.

@willschlitzer
Copy link
Contributor Author

/format

@seisman seisman added the documentation Improvements or additions to documentation label Dec 26, 2020
@seisman seisman added this to the 0.3.0 milestone Dec 26, 2020
@seisman
Copy link
Member

seisman commented Dec 29, 2020

I'm not sure paint_country is a good name for this parameter. GMT.jl uses dcw, but I don't like that one.

seisman
seisman reviewed Dec 29, 2020
View reviewed changes
pygmt/base_plotting.py Outdated Show resolved Hide resolved
@willschlitzer
Copy link
Contributor Author

I'm not sure what a good alias would be; I felt like paint_country is awkward but I wanted the parameter to be descriptive (which I don't think something like dcw is). I'll give it some thought on alternatives.

@willschlitzer
Copy link
Contributor Author

I think dcw may be the best option. While It's doesn't really explain what the argument is, I think it looks cleaner than paint_country.

@willschlitzer @seisman
Update pygmt/base_plotting.py
b597dab 
Co-authored-by: Dongdong Tian <[email protected]>
@willschlitzer
Copy link
Contributor Author

/format

@willschlitzer
Copy link
Contributor Author

/format

seisman
seisman reviewed Jan 18, 2021
View reviewed changes
pygmt/base_plotting.py Outdated Show resolved Hide resolved
seisman
seisman reviewed Jan 18, 2021
View reviewed changes
pygmt/base_plotting.py Outdated Show resolved Hide resolved
pygmt/base_plotting.py Outdated Show resolved Hide resolved
@seisman seisman added enhancement Improving an existing feature and removed documentation Improvements or additions to documentation labels Jan 18, 2021
@seisman seisman changed the title Add paint_country as parameter for coast Add dcw alias to Figure.coast Jan 18, 2021
@seisman seisman changed the title Add dcw alias to Figure.coast Add dcw alias (E) to Figure.coast Jan 18, 2021
@seisman seisman merged commit e3efe39 into GenericMappingTools:master Jan 18, 2021
@willschlitzer willschlitzer deleted the paint-country branch January 21, 2021 09:16
@weiji14 weiji14 mentioned this pull request Jan 21, 2021
Closed
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@willschlitzer @seisman
Add dcw alias (E) to Figure.coast (GenericMappingTools#765)
1df5765 
Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seisman seisman seisman approved these changes

Assignees
No one assigned
Labels
enhancement Improving an existing feature
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@willschlitzer @seisman