Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CI job testing GMT master branch on Windows #756

Merged
merged 7 commits into from
Dec 27, 2020
Merged

Add a CI job testing GMT master branch on Windows #756

merged 7 commits into from
Dec 27, 2020

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 21, 2020 •
edited
Loading

Description of proposed changes

This PR tests PyGMT with GMT master branch on Windows,
using the GMT dev versions from conda-forge.

Note that, on Linux and macOS, we test GMT master branch by building the lastest
GMT source codes. However, on Windows, the GMT dev versions from conda-forge
are one or a few weeks behind the GMT master branch.

Fixes #755.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Notes

  • You can write /format in the first line of a comment to lint the code automatically

@seisman seisman marked this pull request as ready for review December 21, 2020 01:23
@seisman seisman marked this pull request as draft December 21, 2020 01:25
@seisman seisman marked this pull request as ready for review December 21, 2020 02:30
@seisman seisman added the maintenance Boring but important stuff for the core devs label Dec 21, 2020
@seisman seisman added this to the 0.3.0 milestone Dec 21, 2020
@seisman seisman requested a review from a team December 21, 2020 02:39
@seisman seisman requested review from a team and removed request for a team December 22, 2020 20:30
@seisman
Copy link
Member Author

seisman commented Dec 23, 2020

Ping @GenericMappingTools/python for review.

@seisman
Copy link
Member Author

seisman commented Dec 27, 2020

Merge the PR without approval.

@seisman seisman merged commit b8e2bdf into master Dec 27, 2020
@seisman seisman deleted the gmt-master-windows branch December 27, 2020 21:33
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman
Add a CI job testing GMT master branch on Windows (GenericMappingTool…
d251726 
…s#756)

This PR tests PyGMT with GMT master branch on Windows,
using the GMT dev versions from conda-forge.
@weiji14 weiji14 mentioned this pull request Oct 29, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Test GMT master branch on Windows using the conda-forge package
1 participant
@seisman