Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug of Figure.text() when "text" is a non-string array #724

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 10, 2020

Description of proposed changes

See #706 for the bug report.

We need to pass an string-type array to lib.virtualfile_from_vectors
function.

Closes #706.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Notes

  • You can write /format in the first line of a comment to lint the code automatically

See #706 for the bug report.

We need to pass an string-type array to `lib.virtualfile_from_vectors`
function.

Closes #706.
@seisman seisman requested a review from a team December 10, 2020 23:51
@seisman seisman added the bug Something isn't working label Dec 10, 2020
@seisman seisman added this to the 0.3.0 milestone Dec 10, 2020
@seisman seisman changed the title Fix the bug for Figure.text() when "text" is a non-string array Fix a bug of Figure.text() when "text" is a non-string array Dec 11, 2020
@seisman seisman merged commit 2128dd4 into master Dec 11, 2020
@seisman seisman deleted the text-nonstr branch December 11, 2020 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fig.text() doesn't work if "text" is integer or float
2 participants