Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the error message when IPython is not available #701

Merged
merged 1 commit into from
Nov 22, 2020
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Nov 22, 2020

Description of proposed changes

When IPython is not available, fig.show() reports an error:

Cannot find IPython. Make sure you have it installed or use 'external=True' to open in an external viewer.

The error message is out-of-date. Instead, it should report:

Cannot find IPython. Make sure you have it installed or use 'method="external"' to open in an external viewer.

The issue was originally reported at https://forum.generic-mapping-tools.org/t/building-gmt-on-freebsd-12-1-release/967/20.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Notes

  • You can write /format in the first line of a comment to lint the code automatically

When IPython is not available, `fig.show()` reports an error:
```
Cannot find IPython. Make sure you have it installed or use 'external=True' to open in an external viewer.
```

The error message is out-of-date. Instead, it should report:
```
Cannot find IPython. Make sure you have it installed or use 'method="external"' to open in an external viewer.
```
@seisman seisman requested a review from weiji14 November 22, 2020 05:50
@seisman seisman added the bug Something isn't working label Nov 22, 2020
@seisman seisman added this to the 0.3.0 milestone Nov 22, 2020
@seisman seisman requested a review from a team November 22, 2020 05:51
@seisman seisman merged commit 5ca84df into master Nov 22, 2020
@seisman seisman deleted the fix-msg branch November 22, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants