Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert plotting across dateline workarounds #585

Merged
merged 3 commits into from
Sep 5, 2020

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Sep 5, 2020

Description of proposed changes

Remove some workarounds that were added because plotting grids across the dateline would crash, not needed since we've bumped the minimum required GMT version to 6.1.1 at #577. These are cherrypicked commits from #560 to keep diff small. Specifically, this PR will:

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@weiji14 weiji14 added bug Something isn't working skip-changelog Skip adding Pull Request to changelog maintenance Boring but important stuff for the core devs and removed bug Something isn't working labels Sep 5, 2020
@weiji14 weiji14 requested a review from seisman September 5, 2020 22:00
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@weiji14 weiji14 merged commit 960cd0e into master Sep 5, 2020
@weiji14 weiji14 deleted the revert_dateline_workarounds branch September 5, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants