-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gallery example for grdview #502
Add gallery example for grdview #502
Conversation
Two minor comments on this:
|
It might be tough for Scipy Sprint folks to preview the documentation locally, unless they've set up a PyGMT environment, instructions are at https://github.com/GenericMappingTools/pygmt/blob/master/CONTRIBUTING.md#documentation if anyone needs them. Luckily we've got #344, which reminds me, I'll send you an email to invite you as an owner on the Vercel gmt team, since you're part of @GenericMappingTools/python now. Anyways, preview is at https://pygmt-git-fork-liamtoney-grdview-gallery.gmt.now.sh/gallery/grid/grdview_surface.html#plotting-a-surface, or you can click on the "View deployment" button
Haven't tried illumination with |
That is really nifty!
Didn't see anything obvious in the console output. Will have to table for later, it looks alright as is! |
I was able to re-create the code in pure GMT, and the shading performs as expected, so it's a PyGMT grid I/O issue I think. Edit: I think this issue is the same as #364, so I'll just comment there. |
Co-authored-by: Dongdong Tian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@weiji14 is the one implementing the |
Whoops. I saw your approval and merged. Apologies if that was premature. |
It's fine. We can fix it later if @weiji14 wants more. |
Oops, missed it by a few minutes. I actually really like this Ackley function example, definitely better than anything I could have come up with! Aside from a few extra inline comments, I think it's fine as is. We can add them in when the shading works in GMT 6.1 😉 |
Yes the shaded version looks quite nice so I'd like to update this example once we get to 6.1! |
Description of proposed changes
Add an example use of
grdview()
to the gallery. Serves as an example for #433, as well as a refresher for me. 😝Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.