Test timedelta64 dtype arrays with various date/time units #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
weiji14
approved these changes
Nov 6, 2024
| """ | ||
| for unit in ["Y", "M", "W", "D", "h", "m", "s", "ms", "μs"]: | ||
| for unit in ["Y", "M", "W", "D", "h", "m", "s", "ms", "us", "ns", "ps", "fs", "as"]: |
There was a problem hiding this comment.
I think this test was limited to just "μs" because GMT supports up to microsecond for datetime as you mentioned at #464 (comment). But for timedelta, I guess it doesn't matter if we are using nanosecond or lower since it is just a linear scale.
seisman
added a commit
that referenced
this pull request
Nov 6, 2024
seisman
added a commit
that referenced
this pull request
Nov 18, 2024
seisman
added a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
np.timedelta64is internally stored as 64-bit integers. So any date/time units listed at https://numpy.org/doc/stable/reference/arrays.datetime.html#datetime-units are supported.This PR improves the existing test (added in #2884) by testing time units like "ns", "ps", "fs", and "as".
Patches #2884.