Fix the conversion error for pandas.Series with missing values in pandas<=2.1 #3505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
commented
Oct 11, 2024
seisman
added
bug
seisman
changed the title
weiji14
approved these changes
Oct 11, 2024
Co-authored-by: Wei Ji <[email protected]>
seisman
added
final review call
michaelgrund
approved these changes
Oct 11, 2024
seisman
removed
the
final review call
seisman
added a commit
that referenced
this pull request
Oct 16, 2024
…das<=2.1 (#3505) Co-authored-by: Wei Ji <[email protected]>
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See #2844 for the issue report.
It turns out that in pandas <= 2.1, pd.Series with integer values and pd.NA are converted to
objecttype, which can't be recognized later, but in pandas >= 2.2, they are converted to float type.In this PR, we add a workaround for pandas<=2.1 by casting the pd.Series to float type explicitly if it contains pd.NA.
Closes #2844.
As per SPEC 0 policy, support of pandas 2.1 should be dropped in 2025 Q3, so we expect to remove the workaround for PyGMT v0.17.0.