Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine the Oblique Mercator projection pages into one page #3451
Combine the Oblique Mercator projection pages into one page #3451
Changes from all commits
c6c69d5
d7692ed
884b12e
3c06ce2
b29a0a8
cd15b7d
1d154c2
db694d2
f5ab3f7
bd9e1ed
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel it's a little weird to show three mini maps in one gallery thumbnail image (https://pygmt-dev--3451.org.readthedocs.build/en/3451/projections/index.html#cylindric-projections). Since it's just three different ways to specify one projection, maybe we can show three separate maps in this example and only show one of them in the gallery summary page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I combined the three maps into one figure, because the maps for the options Oa and Ob are quite high. And having all three maps in the current size below each other makes the website quite long. But your are right, the thumbnail image looks not optimal.
In commit cd15b7d I tested showing separate maps for using a much smaler sizes for the maps. For the thumbnail image I picked the map for Oc, as the ascept ratio seems to fit best to the thumbnail image card.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to have the figure below each subsection, which is easier to read IMHO. Let's hear what others think about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I have missed this point from your first review comment here. I just worked on removing the subplot. If having separate code blocks within each subsection, I think it's also OK to show the maps separatly, even though the maps have a larger height. However, having them all tree below each other at the end looked not good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new layout.
This file was deleted.
This file was deleted.
This file was deleted.