Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove the pytest-xdist and pytest-rerunfailures plugins from the Benchmarks workflow #3314

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Jul 7, 2024

The Benchmarks workflow crashes frequently (e.g., https://github.com/GenericMappingTools/pygmt/actions/runs/9824664574/job/27124975569?pr=3310) after we added the pytest-xdist and pytest-rerunfailures plugins in #3193.

This PR removes the two plugins from the Benchmarks workflow.

@seisman seisman added maintenance Boring but important stuff for the core devs run/benchmark Trigger the benchmark workflow in PRs labels Jul 7, 2024
@seisman seisman added this to the 0.13.0 milestone Jul 7, 2024
@seisman seisman added run/benchmark Trigger the benchmark workflow in PRs and removed run/benchmark Trigger the benchmark workflow in PRs labels Jul 7, 2024
Copy link

codspeed-hq bot commented Jul 7, 2024

CodSpeed Performance Report

Merging #3314 will degrade performances by 76.54%

Comparing ci/benchmark (f045638) with main (b907b4a)

Summary

❌ 5 regressions
✅ 96 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main ci/benchmark Change
test_contour_matrix[DataFrame] 16.5 ms 69.1 ms -76.06%
test_contour_matrix[Dataset] 19 ms 71.5 ms -73.49%
test_contour_matrix[array] 16.1 ms 68.7 ms -76.54%
test_grdlandmask_no_outgrid 63.1 ms 130.9 ms -51.83%
test_sph2grd_no_outgrid 295.9 ms 408.5 ms -27.56%

@seisman seisman added skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. and removed run/benchmark Trigger the benchmark workflow in PRs labels Jul 7, 2024
@seisman seisman merged commit 41a0fe0 into main Jul 7, 2024
7 of 8 checks passed
@seisman seisman deleted the ci/benchmark branch July 7, 2024 22:43
@seisman seisman removed the needs review This PR has higher priority and needs review. label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants