-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clib: Wrap the GMT API function GMT_Read_VirtualFile #2993
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
changed the title
Wrap GMT_Read_VirtualFile
clib.Session: Wrap the GMT API function GMT_Read_VirtualFile
Jan 12, 2024
seisman
force-pushed
the
api/read_virtualfile
branch
from
January 14, 2024 06:33
0dbe930
to
6be1a10
Compare
seisman
force-pushed
the
api/read_virtualfile
branch
from
January 14, 2024 07:00
6be1a10
to
29702a6
Compare
seisman
added
enhancement
Improving an existing feature
needs review
This PR has higher priority and needs review.
labels
Jan 14, 2024
seisman
commented
Jan 14, 2024
weiji14
approved these changes
Feb 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a tiny suggestion.
Comment on lines
+4
to
+5
from pygmt.datatypes.dataset import _GMT_DATASET | ||
from pygmt.datatypes.grid import _GMT_GRID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Wei Ji <[email protected]>
seisman
added
final review call
This PR requires final review and approval from a second reviewer
and removed
needs review
This PR has higher priority and needs review.
labels
Feb 19, 2024
seisman
removed
the
final review call
This PR requires final review and approval from a second reviewer
label
Feb 19, 2024
2 tasks
seisman
changed the title
clib.Session: Wrap the GMT API function GMT_Read_VirtualFile
clib: Wrap the GMT API function GMT_Read_VirtualFile
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Wrap the GMT API function
GMT_Read_VirtualFile
which can read the data from a GMT virtual file and cast it into standard GMT data types (e.g.,GMT_DATASET
andGMT_GRID
). This API function will be used in supportingGMT_DATASET
/GMT_GRID
data types in PR #2398 and #2729.The same codes are already used in PR #2729 and #2398. This PR is created to make those two PRs smaller and easier to review.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash command is:
/format
: automatically format and lint the code