Let get_clib_path find the path to libgmt on Windows #285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The name of the shared library is
gmt_w64.dll
for 64-bit Windows, andgmt_w32.dll
for 32-bit Windows, and the library is located inC:\programs\gmt6\bin
by default. This PR changesget_clib_path
so that it can return the correct library name for Windows.I've tried to install pygmt on Windows and run the test. The GMT6 binary is the one provided by Joaquim.
The tests give 19 failures. Most of the failures are due to different image size, which may be caused by slightly different ghostscript (the version I use is 9.22). Other failures seems related to the slightly different behaviors of Python packages for different system, and permission issues. See the attached log for details. pytest.log
Although currently we don't have CI tests on Windows, I think we can at least merge this PR into master, so that Windows users can have a try and help us find bugs on Windows.
Working towards #46
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.