-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure.plot: Refactor to increase code readability #2742
Conversation
7965dbf
to
2558c97
Compare
Are there any further changes you wanna make @seisman ? |
No I didn't, I was traveling the last ~4 weeks. However, just saw that Yvonne forwarded the mail to me. Will answer it later. |
Ping @GenericMappingTools/pygmt-maintainers for final review. Will merge in 24 hours if no further comments. |
Did you want to update some of the type hints here, or in #2744? |
I have some other ideas about refactoring The |
Description of proposed changes
The
Figure.plot
method is one of the first GMT modules wrapped in PyGMT and we have kept adding more features into this method but without any refactorings.The current
Figure.plot
codes are difficult to read and maintain. This PR refactors the codes to make it easier to read by grouping the codes based on the data kind.