Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checking GMT Legacy/Dev Tests to the release checklist #2285

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 29, 2022

Description of proposed changes

Related to #2281 (comment).

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added this to the 0.9.0 milestone Dec 29, 2022
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Dec 29, 2022
@seisman seisman marked this pull request as ready for review December 31, 2022 06:38
@seisman seisman marked this pull request as draft January 1, 2023 03:50
@seisman
Copy link
Member Author

seisman commented Jan 1, 2023

We can wait until the GMT team decides if a Mastodon account will be created (c.f. #2244 (comment)).

@seisman seisman marked this pull request as ready for review March 13, 2023 02:45
@seisman
Copy link
Member Author

seisman commented Mar 13, 2023

We can wait until the GMT team decides if a Mastodon account will be created (c.f. #2244 (comment)).

No progress on the Mastodon account and we're going to make a new PyGMT release. So now it's time to review/merge this PR.

@seisman seisman added the needs review This PR has higher priority and needs review. label Mar 13, 2023
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can wait until the GMT team decides if a Mastodon account will be created (c.f. #2244 (comment)).

No progress on the Mastodon account and we're going to make a new PyGMT release. So now it's time to review/merge this PR.

Thanks for the reminder. I've added the Mastodon account discussion to the agenda for the upcoming PyGMT Community Meeting at https://forum.generic-mapping-tools.org/t/pygmt-community-meeting-tuesday-14-march-2023-utc-1800/3734.

.github/ISSUE_TEMPLATE/release_checklist.md Outdated Show resolved Hide resolved
@weiji14 weiji14 added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Mar 13, 2023
@seisman seisman merged commit 34fed4d into main Mar 13, 2023
@seisman seisman deleted the update-release-checklist branch March 13, 2023 06:43
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants