Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plural for the unit of the resolution of datasets (higher 1 arc-xy) #2251

Merged
merged 19 commits into from
Dec 19, 2022

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Dec 16, 2022

Description of proposed changes

This PR aims to use plural for the unit of the resolution of the datasets for resolutions higher than 1 arc-xy:

  • datasets
  • src (documentation)
  • tests
  • helpers
  • examples/gallery
  • examples/tutorials

Related to: #2238 (comment), #2238 (comment)

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@yvonnefroehlich yvonnefroehlich changed the title Use plural for the unit of the resolution of datasets (higher 1 arc-xy) WIP: Use plural for the unit of the resolution of datasets (higher 1 arc-xy) Dec 16, 2022
@yvonnefroehlich yvonnefroehlich added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Dec 16, 2022
@yvonnefroehlich yvonnefroehlich added this to the 0.8.0 milestone Dec 16, 2022
@willschlitzer
Copy link
Contributor

willschlitzer commented Dec 17, 2022

@yvonnefroehlich Is this ready for review? It still has work in progress in the title.

@yvonnefroehlich
Copy link
Member Author

@yvonnefroehlich Is this ready for review? It still has work in progress in the title.

Hopefully I found and updated all occurrences yet... So, if you like and have time you could review this PR. Thanks @willschlitzer!

@yvonnefroehlich yvonnefroehlich changed the title WIP: Use plural for the unit of the resolution of datasets (higher 1 arc-xy) Use plural for the unit of the resolution of datasets (higher 1 arc-xy) Dec 17, 2022
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Dec 18, 2022
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 19, 2022
@seisman seisman merged commit 3c9a1b9 into main Dec 19, 2022
@seisman seisman deleted the fix-typos-10 branch December 19, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants