Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.meca: Fix line and circle of offset parameter for dict/pandas input #2226

Merged
merged 11 commits into from
Dec 20, 2022

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Dec 5, 2022

Description of proposed changes

The line and the small circle are not plotted or modified via the offset parameter when passing a dictionary to the spec parameter of pygmt.Figure.meca.

Fixes / For context see: #2016 (comment)

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the bug Something isn't working label Dec 6, 2022
@seisman seisman added this to the 0.8.0 milestone Dec 6, 2022
@seisman seisman changed the title meca.py: Fix line and circle of offset parameter for dict input Figure.meca: Fix line and circle of offset parameter for dict input Dec 6, 2022
@seisman seisman changed the title Figure.meca: Fix line and circle of offset parameter for dict input Figure.meca: Fix line and circle of offset parameter for dict/pandas input Dec 6, 2022
@yvonnefroehlich yvonnefroehlich changed the title Figure.meca: Fix line and circle of offset parameter for dict/pandas input WIP: Figure.meca: Fix line and circle of offset parameter for dict/pandas input Dec 16, 2022
@yvonnefroehlich yvonnefroehlich changed the title WIP: Figure.meca: Fix line and circle of offset parameter for dict/pandas input Figure.meca: Fix line and circle of offset parameter for dict/pandas input Dec 18, 2022
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Dec 19, 2022
@seisman seisman merged commit 3f8c272 into main Dec 20, 2022
@seisman seisman deleted the fix-meca-offset-line branch December 20, 2022 07:28
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 20, 2022
@yvonnefroehlich yvonnefroehlich mentioned this pull request Dec 20, 2022
65 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants