-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure.meca: Fix line and circle of offset parameter for dict/pandas input #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
changed the title
meca.py: Fix line and circle of offset parameter for dict input
Figure.meca: Fix line and circle of offset parameter for dict input
Dec 6, 2022
seisman
changed the title
Figure.meca: Fix line and circle of offset parameter for dict input
Figure.meca: Fix line and circle of offset parameter for dict/pandas input
Dec 6, 2022
seisman
reviewed
Dec 6, 2022
yvonnefroehlich
changed the title
Figure.meca: Fix line and circle of offset parameter for dict/pandas input
WIP: Figure.meca: Fix line and circle of offset parameter for dict/pandas input
Dec 16, 2022
9 tasks
yvonnefroehlich
changed the title
WIP: Figure.meca: Fix line and circle of offset parameter for dict/pandas input
Figure.meca: Fix line and circle of offset parameter for dict/pandas input
Dec 18, 2022
seisman
approved these changes
Dec 19, 2022
seisman
added
the
final review call
This PR requires final review and approval from a second reviewer
label
Dec 19, 2022
michaelgrund
approved these changes
Dec 20, 2022
seisman
removed
the
final review call
This PR requires final review and approval from a second reviewer
label
Dec 20, 2022
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The line and the small circle are not plotted or modified via the
offset
parameter when passing a dictionary to thespec
parameter ofpygmt.Figure.meca
.Fixes / For context see: #2016 (comment)
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version