Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add load_earth_magnetic_anomaly function for Earth magnetic anomaly dataset #2196
Add load_earth_magnetic_anomaly function for Earth magnetic anomaly dataset #2196
Changes from 12 commits
9de5e07
6de890d
f099e4a
aeebb6a
9d41121
0ac7afb
0a22439
666e1b7
d297910
b815b8b
078c175
4bd9d75
3e8fe66
9d73a2e
952d34c
0e1417b
f8f6b41
4e0e2ae
4edfb7b
a44a8c4
4df2865
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert in magnetic anomalies, but having a
horizontal_datum
seems strange. Is the magnetic anomaly referenced to the geoid somehow?Also, not related to this PR, but I notice that
horizontal_datum
is also set as an attribute for theearth_age
dataset at L96. Is seafloor crustal age also measured relative to a datum?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment #2200 (comment).
I think
horizontal_datum
means the coordinate system for longitude/latitude.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, the datum in GMT is mainly related to the ellipsoid and its positioning. As you can see from
gmt mapproject -Qd
, the positioning of the ellipsoid is given as the difference in three directions between the center of the ellipsoid and the center of the earth. As toearth_age
, I think it does not have height information,horizontal_datum
is enough. I don't konw much about magnetic anomalies.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to leave
horizontal_datum
in; per my understanding (and from the comments above) it is the system that aligns coordinates with the actual locations on Earth. So I assume it still applies to the magnetic anomaly map?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, leave it in. Thanks for the clarification everyone!