-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load_earth_relief: Add the support of data source 'GEBCOSI' #2192
Conversation
This PR has some conflicts with the main branch. @willschlitzer Do you want to fix these conflicts and get the PR merged before PR #2200? Or we can focus on PR #2200 first and add the "GEBCOSI" data source later. |
/format |
I think it makes sense to finish #2200 first. But if you want to add the named tuples in to the current PR, as opposed to a later one, I would prefer to finish this first, since I suspect it would be some time before I could merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except for the above comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…appingTools#2192) Co-authored-by: Dongdong Tian <[email protected]>
This pull request adds the GEBCOSI data source to
load_earth_relief
Addresses #1786
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version