Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_earth_relief: Add the support of data source 'GEBCOSI' #2192

Merged
merged 9 commits into from
Nov 25, 2022

Conversation

willschlitzer
Copy link
Contributor

This pull request adds the GEBCOSI data source to load_earth_relief

Addresses #1786

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the feature Brand new feature label Nov 18, 2022
@willschlitzer willschlitzer self-assigned this Nov 18, 2022
@willschlitzer willschlitzer added this to the 0.8.0 milestone Nov 18, 2022
@willschlitzer willschlitzer changed the title Add GEBCOSI data source to load_earth_relief load_earth_relief: Add the support of data source 'GEBCOSI' Nov 19, 2022
@seisman
Copy link
Member

seisman commented Nov 23, 2022

This PR has some conflicts with the main branch.

@willschlitzer Do you want to fix these conflicts and get the PR merged before PR #2200? Or we can focus on PR #2200 first and add the "GEBCOSI" data source later.

@willschlitzer
Copy link
Contributor Author

/format

@willschlitzer
Copy link
Contributor Author

This PR has some conflicts with the main branch.

@willschlitzer Do you want to fix these conflicts and get the PR merged before PR #2200? Or we can focus on PR #2200 first and add the "GEBCOSI" data source later.

I think it makes sense to finish #2200 first. But if you want to add the named tuples in to the current PR, as opposed to a later one, I would prefer to finish this first, since I suspect it would be some time before I could merge this.

pygmt/helpers/testing.py Outdated Show resolved Hide resolved
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for the above comment.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Nov 24, 2022
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think merging this PR first and then doing the refactor in #2200 will be better (good to have more unit tests in place before refactoring).

Oh, and can we close #1786 after this PR is merged?

pygmt/datasets/earth_relief.py Show resolved Hide resolved
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Nov 25, 2022
@seisman seisman merged commit 3e33467 into main Nov 25, 2022
@seisman seisman deleted the load-earth-relief/gebcosi branch November 25, 2022 15:35
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Brand new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants