Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert bug report markdown issue template into yaml configured form #2091

Merged
merged 5 commits into from
Sep 14, 2022

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Aug 29, 2022

Description of proposed changes

A more structured and user friendly way of filling out bug reports.

Preview at https://github.com/GenericMappingTools/pygmt/blob/yaml-issue-form/.github/ISSUE_TEMPLATE/bug_report.yaml

Examples:

References:

Addresses #2050. Replaces the original markdown issue form added in e99e15f

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 added the documentation Improvements or additions to documentation label Aug 29, 2022
@weiji14 weiji14 added this to the 0.8.0 milestone Aug 29, 2022
@weiji14 weiji14 self-assigned this Aug 29, 2022
Copy link
Member Author

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Literally just translated the markdown template to a YAML template for now, let me know if there's anything to improve upon!

.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Sep 8, 2022
.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
@weiji14 weiji14 marked this pull request as ready for review September 14, 2022 17:23
@weiji14 weiji14 enabled auto-merge (squash) September 14, 2022 17:54
@weiji14 weiji14 disabled auto-merge September 14, 2022 19:00
@weiji14 weiji14 merged commit 72a7398 into main Sep 14, 2022
@weiji14 weiji14 deleted the yaml-issue-form branch September 14, 2022 19:01
@weiji14 weiji14 removed the final review call This PR requires final review and approval from a second reviewer label Sep 14, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…enericMappingTools#2091)

A more structured and user friendly way of filling out bug reports. Syntax documentation at https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema

* Give hints on how to provide a Minimal Complete Verifiable Example

Adapted from https://github.com/pydata/xarray/blob/v2022.06.0/.github/ISSUE_TEMPLATE/bugreport.yml.

* Instruct to provide OS, installation method and error message
* Remove backslashes from pygmt.show_versions command

Co-authored-by: Max Jones <[email protected]>
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs and removed documentation Improvements or additions to documentation labels Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants