Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor grdview and grdimage to use virtualfile_from_data #1988

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Refactor grdview and grdimage to use virtualfile_from_data #1988

merged 1 commit into from
Jul 11, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Jul 3, 2022

Description of proposed changes

Fixes #949

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the maintenance Boring but important stuff for the core devs label Jul 3, 2022
@seisman seisman added this to the 0.8.0 milestone Jul 3, 2022
@seisman seisman added the needs review This PR has higher priority and needs review. label Jul 5, 2022
@seisman seisman requested a review from a team July 9, 2022 15:19
@maxrjones maxrjones added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jul 10, 2022
@weiji14 weiji14 mentioned this pull request Jul 11, 2022
Closed
6 tasks
weiji14
weiji14 approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping on top of things @seisman!

@weiji14 weiji14 merged commit 906bb86 into main Jul 11, 2022
@weiji14 weiji14 deleted the virtualfile-from-data branch July 11, 2022 02:18
@weiji14 weiji14 removed the final review call This PR requires final review and approval from a second reviewer label Jul 11, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman
Refactor grdview and grdimage to use virtualfile_from_data (GenericMa…
ad3867a 
…ppingTools#1988)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

@maxrjones maxrjones maxrjones approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

Universal virtualfile_from_data function to replace virtualfile_from_grid/matrix/vectors
3 participants
@seisman @maxrjones @weiji14