Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update baseline images for GMT 6.4 #1883

Merged
merged 38 commits into from
Aug 7, 2022
Merged

Update baseline images for GMT 6.4 #1883

merged 38 commits into from
Aug 7, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 15, 2022 •
edited
Loading

Address #1989.

Closes #1885.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman mentioned this pull request Apr 15, 2022
Merged
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs longterm Long standing issues that need to be resolved labels Apr 15, 2022
@seisman seisman added this to the 0.7.0 milestone Apr 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2022 •
edited
Loading

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_basemap_compass.png
modified pygmt/tests/baseline/test_basemap_polar.png
modified pygmt/tests/baseline/test_basemap_utm_projection.png
modified pygmt/tests/baseline/test_config_font_annot.png
modified pygmt/tests/baseline/test_config_font_one.png
modified pygmt/tests/baseline/test_config_format_date_map.png
modified pygmt/tests/baseline/test_contour_vec.png
modified pygmt/tests/baseline/test_geopandas_plot3d_default_cube.png
modified pygmt/tests/baseline/test_geopandas_plot3d_non_default_circle.png
modified pygmt/tests/baseline/test_grdcontour.png
modified pygmt/tests/baseline/test_grdcontour_labels.png
modified pygmt/tests/baseline/test_grdimage.png
modified pygmt/tests/baseline/test_grdimage_file.png
modified pygmt/tests/baseline/test_grdimage_global_subset.png
modified pygmt/tests/baseline/test_grdimage_over_dateline.png
modified pygmt/tests/baseline/test_grdimage_slice.png
modified pygmt/tests/baseline/test_grdview_on_a_plane_with_colored_frontal_facade.png
modified pygmt/tests/baseline/test_grdview_with_cmap_for_image_plot.png
modified pygmt/tests/baseline/test_grdview_with_perspective.png
modified pygmt/tests/baseline/test_grdview_with_perspective_and_zaxis_frame.png
modified pygmt/tests/baseline/test_image.png
modified pygmt/tests/baseline/test_inset_context_manager.png
modified pygmt/tests/baseline/test_legend_default_position.png
modified pygmt/tests/baseline/test_legend_entries.png
modified pygmt/tests/baseline/test_legend_position.png
modified pygmt/tests/baseline/test_legend_specfile.png
modified pygmt/tests/baseline/test_logo.png
modified pygmt/tests/baseline/test_makecpt_categorical.png
modified pygmt/tests/baseline/test_makecpt_continuous.png
modified pygmt/tests/baseline/test_makecpt_plot_colorbar_scaled_with_series.png
modified pygmt/tests/baseline/test_makecpt_reverse_color_and_zsign.png
modified pygmt/tests/baseline/test_makecpt_reverse_color_only.png
modified pygmt/tests/baseline/test_makecpt_truncated_zlow_zhigh.png
modified pygmt/tests/baseline/test_meca_spec_1d_array.png
modified pygmt/tests/baseline/test_meca_spec_dataframe.png
modified pygmt/tests/baseline/test_plot3d_colors_sizes_proj.png
modified pygmt/tests/baseline/test_plot3d_matrix.png
modified pygmt/tests/baseline/test_plot3d_ogrgmt_file_multipoint_default_style.png
modified pygmt/tests/baseline/test_plot3d_ogrgmt_file_multipoint_non_default_style.png
modified pygmt/tests/baseline/test_plot3d_projection.png
modified pygmt/tests/baseline/test_plot3d_red_circles_zscale.png
modified pygmt/tests/baseline/test_plot_colors_sizes_proj.png
modified pygmt/tests/baseline/test_plot_matrix.png
modified pygmt/tests/baseline/test_plot_shapefile.png
modified pygmt/tests/baseline/test_rose_2d_array_multiple.png
modified pygmt/tests/baseline/test_rose_2d_array_single.png
modified pygmt/tests/baseline/test_solar_set_terminator_datetime.png
modified pygmt/tests/baseline/test_solar_terminators.png
modified pygmt/tests/baseline/test_text_fill.png
modified pygmt/tests/baseline/test_text_justify_bottom_right_and_top_left.png
modified pygmt/tests/baseline/test_text_multiple_lines_of_text.png
modified pygmt/tests/baseline/test_text_position.png
modified pygmt/tests/baseline/test_text_position_offset_with_line.png
modified pygmt/tests/baseline/test_text_single_line_of_text.png
modified pygmt/tests/baseline/test_velo_numpy_array_numeric_only.png
modified pygmt/tests/baseline/test_velo_pandas_dataframe.png
modified pygmt/tests/baseline/test_wiggle.png

Image diff(s)

Added images

Modified images

Path Old New
test_basemap_compass.png
test_basemap_polar.png
test_basemap_utm_projection.png
test_config_font_annot.png
test_config_font_one.png
test_config_format_date_map.png
test_contour_vec.png
test_geopandas_plot3d_default_cube.png
test_geopandas_plot3d_non_default_circle.png
test_grdcontour.png
test_grdcontour_labels.png
test_grdimage.png
test_grdimage_file.png
test_grdimage_global_subset.png
test_grdimage_over_dateline.png
test_grdimage_slice.png
test_grdview_on_a_plane_with_colored_frontal_facade.png
test_grdview_with_cmap_for_image_plot.png
test_grdview_with_perspective.png
test_grdview_with_perspective_and_zaxis_frame.png
test_image.png
test_inset_context_manager.png
test_legend_default_position.png
test_legend_entries.png
test_legend_position.png
test_legend_specfile.png
test_logo.png
test_makecpt_categorical.png
test_makecpt_continuous.png
test_makecpt_plot_colorbar_scaled_with_series.png
test_makecpt_reverse_color_and_zsign.png
test_makecpt_reverse_color_only.png
test_makecpt_truncated_zlow_zhigh.png
test_meca_spec_1d_array.png
test_meca_spec_dataframe.png
test_plot3d_colors_sizes_proj.png
test_plot3d_matrix.png
test_plot3d_ogrgmt_file_multipoint_default_style.png
test_plot3d_ogrgmt_file_multipoint_non_default_style.png
test_plot3d_projection.png
test_plot3d_red_circles_zscale.png
test_plot_colors_sizes_proj.png
test_plot_matrix.png
test_plot_shapefile.png
test_rose_2d_array_multiple.png
test_rose_2d_array_single.png
test_solar_set_terminator_datetime.png
test_solar_terminators.png
test_text_fill.png
test_text_justify_bottom_right_and_top_left.png
test_text_multiple_lines_of_text.png
test_text_position.png
test_text_position_offset_with_line.png
test_text_single_line_of_text.png
test_velo_numpy_array_numeric_only.png
test_velo_pandas_dataframe.png
test_wiggle.png

Report last updated at commit b5f15c9

@seisman seisman changed the base branch from flake8-to-flakeheaven to main April 22, 2022 15:59
@michaelgrund michaelgrund mentioned this pull request Apr 24, 2022
Closed
69 tasks
@seisman
Copy link
Member Author

seisman commented Apr 30, 2022 •
edited by genericmappingtools-bot bot
Loading

/test-gmt-dev
https://github.com/GenericMappingTools/pygmt/actions/runs/2250439253

@seisman
Copy link
Member Author

seisman commented May 5, 2022 •
edited by genericmappingtools-bot bot
Loading

/test-gmt-dev
https://github.com/GenericMappingTools/pygmt/actions/runs/2274271836

@seisman seisman modified the milestones: 0.7.0, 0.8.0 Jun 23, 2022
@seisman seisman changed the title WIP: Update baseline images for GMT 6.4 Update baseline images for GMT 6.4 Aug 4, 2022
@seisman seisman marked this pull request as ready for review August 4, 2022 02:22
@seisman seisman added needs review This PR has higher priority and needs review. and removed longterm Long standing issues that need to be resolved labels Aug 4, 2022
@seisman
Copy link
Member Author

seisman commented Aug 4, 2022

Most of the changes are caused by tiny changes in GMT 6.4, and a few tests are modified to simplify the tests.

Now all tests pass except 2 failures on Linux and macOS and 4 failures on Windows.

The 2 failures on Linux and macOS are reported in #1929 and will be addressed in separate PRs after more discussions. The two more failures on Windows will be explored later.

@GenericMappingTools/pygmt-maintainers Please give this PR a review.

@seisman seisman requested a review from a team August 6, 2022 07:41
@seisman seisman removed the needs review This PR has higher priority and needs review. label Aug 7, 2022
@seisman seisman merged commit 104108f into main Aug 7, 2022
@seisman seisman deleted the gmt-6.4 branch August 7, 2022 11:27
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman
Update baseline images for GMT 6.4 (GenericMappingTools#1883)
f77334f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxrjones maxrjones maxrjones approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

List of failing tests for GMT 6.4
3 participants
@seisman @maxrjones @weiji14