Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor build_arg_string to also deal with infile and outfile #1837

Merged
merged 8 commits into from
Apr 4, 2022
Merged

Refactor build_arg_string to also deal with infile and outfile #1837

merged 8 commits into from
Apr 4, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 21, 2022 •
edited
Loading

Description of proposed changes

Closes #1832.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman mentioned this pull request Mar 29, 2022
Closed
seisman
seisman commented Mar 30, 2022
View reviewed changes
pygmt/helpers/utils.py Outdated Show resolved Hide resolved
weiji14
weiji14 reviewed Apr 1, 2022
View reviewed changes
pygmt/helpers/utils.py Outdated Show resolved Hide resolved
@seisman seisman added the maintenance Boring but important stuff for the core devs label Apr 2, 2022
@seisman seisman added this to the 0.6.1 milestone Apr 2, 2022
weiji14
weiji14 approved these changes Apr 3, 2022
View reviewed changes
pygmt/src/blockm.py
lib.call_module(module=block_method, args=arg_str)
lib.call_module(
module=block_method,
args=build_arg_string(kwargs, infile=infile, outfile=outfile),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still having mixed feeling about having kwargs as the first argument here, but I guess it works 🙃

@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Apr 3, 2022
@seisman
Copy link
Member Author

seisman commented Apr 3, 2022

This PR will conflict with PR #1857 or #1862, due to changes in grd2cpt and makecpt. We need to decide which PR should be merged first.

@weiji14
Copy link
Member

weiji14 commented Apr 3, 2022

This PR will conflict with PR #1857 or #1862, due to changes in grd2cpt and makecpt. We need to decide which PR should be merged first.

Merge this one (#1837) first, so that you can proceed with #1831/#1832. The conflicts in #1857 and #1862 can be resolved later.

@seisman seisman marked this pull request as ready for review April 3, 2022 15:56
@seisman seisman merged commit a1924e8 into main Apr 4, 2022
@seisman seisman deleted the refactor-build_arg_string branch April 4, 2022 07:24
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 4, 2022
@weiji14 weiji14 changed the title Refractor build_arg_string to also deal with infile and outfile Refactor build_arg_string to also deal with infile and outfile Apr 4, 2022
@seisman seisman mentioned this pull request May 4, 2022
Merged
6 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman
Refractor build_arg_string to also deal with infile and outfile (Gene…
b4d36f2 
…ricMappingTools#1837)
@seisman seisman mentioned this pull request Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.

which(), image() and legend() don't support pathlib.Path inputs
2 participants
@seisman @weiji14