Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove grdimage, legend and plot3d xfail markers #1794

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Remove grdimage, legend and plot3d xfail markers #1794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions pygmt/tests/test_grdimage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,6 @@ def test_grdimage_slice(grid):


@pytest.mark.mpl_image_compare
@pytest.mark.xfail(
condition=gmt_version > Version("6.3.0"),
reason="Grid extension bug affects baseline image; "
"fixed in https://github.com/GenericMappingTools/gmt/pull/6175.",
)
def test_grdimage_file():
"""
Plot an image using file input.
Expand Down
16 changes: 0 additions & 16 deletions pygmt/tests/test_legend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@


@pytest.mark.mpl_image_compare
@pytest.mark.xfail(
condition=gmt_version > Version("6.3.0"),
reason="Defaults updated in https://github.com/GenericMappingTools/gmt/pull/6165",
)
def test_legend_position():
"""
Test that plots a position with each of the four legend coordinate systems.
Expand All @@ -31,10 +27,6 @@ def test_legend_position():


@pytest.mark.mpl_image_compare
@pytest.mark.xfail(
condition=gmt_version > Version("6.3.0"),
reason="Defaults updated in https://github.com/GenericMappingTools/gmt/pull/6165",
)
def test_legend_default_position():
"""
Test using the default legend position.
Expand All @@ -51,10 +43,6 @@ def test_legend_default_position():


@pytest.mark.mpl_image_compare
@pytest.mark.xfail(
condition=gmt_version > Version("6.3.0"),
reason="Defaults updated in https://github.com/GenericMappingTools/gmt/pull/6165",
)
def test_legend_entries():
"""
Test different marker types/shapes.
Expand All @@ -76,10 +64,6 @@ def test_legend_entries():


@pytest.mark.mpl_image_compare
@pytest.mark.xfail(
condition=gmt_version > Version("6.3.0"),
reason="Defaults updated in https://github.com/GenericMappingTools/gmt/pull/6165",
)
def test_legend_specfile():
"""
Test specfile functionality.
Expand Down
5 changes: 0 additions & 5 deletions pygmt/tests/test_plot3d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
Tests plot3d.
"""
import os
import sys

import numpy as np
import pytest
Expand Down Expand Up @@ -334,10 +333,6 @@ def test_plot3d_matrix(data, region, color):
return fig


@pytest.mark.xfail(
condition=sys.platform == "win32",
reason="Wrong plot generated on Windows due to incorrect -i parameter parsing",
)
@pytest.mark.mpl_image_compare
def test_plot3d_matrix_color(data, region):
"""
Expand Down