Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update baseline images for the GMT 6.4 part 1 #1791

Closed
wants to merge 8 commits into from

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 7, 2022

Description of proposed changes

Recent upstream GMT changes break some PyGMT tests. Some failures are due to very tiny changes so we just need to update the baseline images when we bump to GMT 6.4.0. However, some failures are caused by new bugs in recent changes (for example GenericMappingTools/gmt#6213 (comment)). It becomes difficult to find these GMT bugs because we have both good and bad failures.

This PR tries to update baseline images for good failures with only tiny changes. Any remaining failures likely reflect new upstream bugs or wrong baseline images.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2022

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_contour_vec.png
modified pygmt/tests/baseline/test_geopandas_plot3d_default_cube.png
modified pygmt/tests/baseline/test_geopandas_plot3d_non_default_circle.png
modified pygmt/tests/baseline/test_grdcontour.png
modified pygmt/tests/baseline/test_grdcontour_labels.png
modified pygmt/tests/baseline/test_meca_spec_1d_array.png
modified pygmt/tests/baseline/test_meca_spec_dataframe.png
modified pygmt/tests/baseline/test_solar_terminators.png
modified pygmt/tests/baseline/test_velo_numpy_array_numeric_only.png
modified pygmt/tests/baseline/test_velo_pandas_dataframe.png
modified pygmt/tests/baseline/test_wiggle.png

Image diff(s)

Added images

Modified images

Path Old New
test_contour_vec.png
test_geopandas_plot3d_default_cube.png
test_geopandas_plot3d_non_default_circle.png
test_grdcontour.png
test_grdcontour_labels.png
test_meca_spec_1d_array.png
test_meca_spec_dataframe.png
test_solar_terminators.png
test_velo_numpy_array_numeric_only.png
test_velo_pandas_dataframe.png
test_wiggle.png

Report last updated at commit b089189

@maxrjones
Copy link
Member

Is the plan to keep this PR open until we bump to 6.4.0?

@seisman
Copy link
Member Author

seisman commented Mar 7, 2022

Is the plan to keep this PR open until we bump to 6.4.0?

Yes, otherwise tests in the main branch will break.

@weiji14 weiji14 added the longterm Long standing issues that need to be resolved label Mar 10, 2022
@seisman seisman added this to the 0.7.0 milestone Mar 18, 2022
@maxrjones
Copy link
Member

This branch is really useful to have for testing GMT PRs. I get lots of failures locally (47), so I think it's time for another round of updates for the small changes. Would you have time to update the baseline images @seisman? Or let me know if you'd want me to push to this branch.

@seisman
Copy link
Member Author

seisman commented Apr 5, 2022

This branch is really useful to have for testing GMT PRs. I get lots of failures locally (47), so I think it's time for another round of updates for the small changes. Would you have time to update the baseline images @seisman? Or let me know if you'd want me to push to this branch.

@meghanrjones Feel free to push any changes to this branch.

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog and removed longterm Long standing issues that need to be resolved labels Apr 14, 2022
@seisman seisman changed the title Update baseline images for the GMT dev Update baseline images for the GMT 6.4 part 1 Apr 14, 2022
@weiji14 weiji14 added the longterm Long standing issues that need to be resolved label Apr 15, 2022
@seisman seisman changed the base branch from main to gmt-6.4 April 16, 2022 11:53
@seisman
Copy link
Member Author

seisman commented Apr 16, 2022

/test-gmt-dev
https://github.com/GenericMappingTools/pygmt/actions/runs/2176685646

@seisman seisman marked this pull request as ready for review April 18, 2022 00:39
@seisman seisman removed the longterm Long standing issues that need to be resolved label Apr 18, 2022
@seisman
Copy link
Member Author

seisman commented Apr 18, 2022

In this PR, 11 baseline images are updated due to tiny differences introduced in the upcoming GMT 6.4. See #1791 (comment) for the old and new baselines.

@seisman seisman changed the title Update baseline images for the GMT 6.4 part 1 WIP: Update baseline images for the GMT 6.4 part 1 Apr 18, 2022
@seisman seisman closed this Apr 19, 2022
@seisman seisman deleted the update-baseline-images-for-gmt-dev branch April 19, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants