-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Update baseline images for the GMT 6.4 part 1 #1791
Conversation
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Added imagesModified imagesReport last updated at commit b089189 |
Is the plan to keep this PR open until we bump to 6.4.0? |
Yes, otherwise tests in the main branch will break. |
This branch is really useful to have for testing GMT PRs. I get lots of failures locally (47), so I think it's time for another round of updates for the small changes. Would you have time to update the baseline images @seisman? Or let me know if you'd want me to push to this branch. |
@meghanrjones Feel free to push any changes to this branch. |
In this PR, 11 baseline images are updated due to tiny differences introduced in the upcoming GMT 6.4. See #1791 (comment) for the old and new baselines. |
Description of proposed changes
Recent upstream GMT changes break some PyGMT tests. Some failures are due to very tiny changes so we just need to update the baseline images when we bump to GMT 6.4.0. However, some failures are caused by new bugs in recent changes (for example GenericMappingTools/gmt#6213 (comment)). It becomes difficult to find these GMT bugs because we have both good and bad failures.
This PR tries to update baseline images for good failures with only tiny changes. Any remaining failures likely reflect new upstream bugs or wrong baseline images.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version