Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP29: Test PyGMT on NumPy 1.22 #1701

Merged
merged 1 commit into from
Jan 14, 2022
Merged

NEP29: Test PyGMT on NumPy 1.22 #1701

merged 1 commit into from
Jan 14, 2022

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Jan 13, 2022

Description of proposed changes

Bumps numpy from 1.21.4 to 1.22.0 released on 31 December 2021.

This is in line with PyGMT's policy on NEP29 at https://www.pygmt.org/v0.5.0/maintenance.html#dependencies-policy, xref #1074.

Note that the branch protection rules at https://github.com/GenericMappingTools/pygmt/settings/branches will need to be changed to use Python 3.9/Numpy 1.22 instead of Python 3.9/Numpy 1.21 before this Pull Request is merged.

Supersedes #1355

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Jan 13, 2022
@weiji14 weiji14 added this to the 0.6.0 milestone Jan 13, 2022
@weiji14 weiji14 self-assigned this Jan 13, 2022
@weiji14 weiji14 marked this pull request as ready for review January 13, 2022 14:04
@weiji14 weiji14 merged commit f84851a into main Jan 14, 2022
@weiji14 weiji14 deleted the nep29/numpy-1.22 branch January 14, 2022 00:05
@seisman seisman mentioned this pull request Dec 20, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants