Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pygmt.surface: Reorder input parameters to 'data, x, y, z' #1562

Merged
merged 1 commit into from
Oct 3, 2021

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

Address #1479

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund michaelgrund added the deprecation Deprecating a feature label Oct 2, 2021
@michaelgrund michaelgrund added this to the 0.5.0 milestone Oct 2, 2021
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Oct 2, 2021
@weiji14 weiji14 changed the title surface: Reorder input parameters to 'data, x, y, z' pygmt.surface: Reorder input parameters to 'data, x, y, z' Oct 3, 2021
@weiji14 weiji14 merged commit e8397c5 into main Oct 3, 2021
@weiji14 weiji14 deleted the surface-reorder-paras branch October 3, 2021 02:15
@weiji14 weiji14 removed the final review call This PR requires final review and approval from a second reviewer label Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants