-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand table-like input options for Figure.contour #1531
Conversation
@weiji14, can you clarify whether each function needs a test for every input option (relates to #1455 (review))? #1523 added a test that covers each option (except geopandas). So, to me it seems that using |
On second thought, maybe not every function since it does get redundant. But I feel it would be nice to test at least 1 for the clib, 1 data processing function (done for nearneighbor), and 1 for a plotting function. So I'd add a parametrize test to |
Thanks for the input, I added one to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done :)
…ls#1531) * Expand table-like input options for Figure.contour * Test pandas, numpy, xarray input in test_contour.py
Description of proposed changes
This PR expands table-like input options for Figure.contour while refactoring to use virtualfile_from_data.
Addresses #949
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version