Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing aliases to pygmt.Figure.wiggle #1498

Merged
merged 6 commits into from
Sep 14, 2021
Merged

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

This PR adds the common options coltypes, transparency and wrap to the pygmt.Figure.wiggle method.

Addresses #1445

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

This PR adds the common options coltypes, transparency and wrap to the pygmt.Figure.wiggle method.

Addresses #1445
@michaelgrund michaelgrund added the documentation Improvements or additions to documentation label Sep 12, 2021
@michaelgrund michaelgrund added this to the 0.5.0 milestone Sep 12, 2021
@@ -23,10 +23,13 @@
c="panel",
d="nodata",
e="find",
f="coltypes",
g="gap",
h="header",
i="columns",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i should be incols rather than columns. Would you be willing to open a PR similar to #1306 for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened a corresponding PR in #1504.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1504 should be merged before this PR.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Sep 13, 2021
@seisman seisman merged commit 09cfc7c into main Sep 14, 2021
@seisman seisman deleted the add-comm-ops-wiggle branch September 14, 2021 04:59
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Sep 14, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants